summaryrefslogtreecommitdiff
path: root/zebra/tc_netlink.c
diff options
context:
space:
mode:
authorDonald Sharp <donaldsharp72@gmail.com>2023-09-07 09:29:57 -0400
committerGitHub <noreply@github.com>2023-09-07 09:29:57 -0400
commitd27aba62b0e541fe0e689f911310cef7b1609f14 (patch)
tree553ae05c8c374113eedb784328256e06197e3d4f /zebra/tc_netlink.c
parent9c36b56d4cf72f665785a7761d7c2ece3358ee59 (diff)
parent7f5385156a37526100d4a7d7ba213719ba0f4a07 (diff)
Merge pull request #14363 from FRRouting/mergify/bp/stable/9.0/pr-14358base_fuzz_20230907
zebra: Prevent Null pointer deref (backport #14358)
Diffstat (limited to 'zebra/tc_netlink.c')
-rw-r--r--zebra/tc_netlink.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/zebra/tc_netlink.c b/zebra/tc_netlink.c
index 679dc80a58..d0f4ed6d18 100644
--- a/zebra/tc_netlink.c
+++ b/zebra/tc_netlink.c
@@ -703,6 +703,8 @@ int netlink_qdisc_change(struct nlmsghdr *h, ns_id_t ns_id, int startup)
{
struct tcmsg *tcm;
struct zebra_tc_qdisc qdisc = {};
+ enum tc_qdisc_kind kind = TC_QDISC_UNSPEC;
+ const char *kind_str = "Unknown";
int len;
struct rtattr *tb[TCA_MAX + 1];
@@ -722,9 +724,11 @@ int netlink_qdisc_change(struct nlmsghdr *h, ns_id_t ns_id, int startup)
tcm = NLMSG_DATA(h);
netlink_parse_rtattr(tb, TCA_MAX, TCA_RTA(tcm), len);
- const char *kind_str = (const char *)RTA_DATA(tb[TCA_KIND]);
+ if (RTA_DATA(tb[TCA_KIND])) {
+ kind_str = (const char *)RTA_DATA(tb[TCA_KIND]);
- enum tc_qdisc_kind kind = tc_qdisc_str2kind(kind_str);
+ kind = tc_qdisc_str2kind(kind_str);
+ }
qdisc.qdisc.ifindex = tcm->tcm_ifindex;