diff options
| author | Donald Sharp <sharpd@nvidia.com> | 2022-06-15 07:31:53 -0400 |
|---|---|---|
| committer | Donald Sharp <sharpd@nvidia.com> | 2022-06-15 10:34:30 -0400 |
| commit | 7c4910cead592c5133940633343b176e30fe7aed (patch) | |
| tree | 0e756c56cbbfc47c1bf2a05b66657668624ec5d9 /zebra/ioctl.c | |
| parent | 442321664b6a8e99b9d2a18a8c33826d4f55c508 (diff) | |
zebra: Attempt to make ioctl.c have a bit more useful log messges
While examining the code, it was noticed that there was a chance
to improve the log output in some cases to give a fuller understanding
of what went wrong where.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Diffstat (limited to 'zebra/ioctl.c')
| -rw-r--r-- | zebra/ioctl.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/zebra/ioctl.c b/zebra/ioctl.c index 239763754b..6311400251 100644 --- a/zebra/ioctl.c +++ b/zebra/ioctl.c @@ -160,7 +160,8 @@ void if_get_mtu(struct interface *ifp) #if defined(SIOCGIFMTU) if (vrf_if_ioctl(SIOCGIFMTU, (caddr_t)&ifreq, ifp->vrf->vrf_id) < 0) { - zlog_info("Can't lookup mtu by ioctl(SIOCGIFMTU)"); + zlog_info("Can't lookup mtu by ioctl(SIOCGIFMTU) for %s(%u)", + ifp->name, ifp->vrf->vrf_id); ifp->mtu6 = ifp->mtu = -1; return; } @@ -171,7 +172,8 @@ void if_get_mtu(struct interface *ifp) zebra_interface_up_update(ifp); #else - zlog_info("Can't lookup mtu on this system"); + zlog_info("Can't lookup mtu on this system for %s(%u)", ifp->name, + ifp->vrf->vrf_id); ifp->mtu6 = ifp->mtu = -1; #endif } @@ -512,7 +514,8 @@ int if_set_flags(struct interface *ifp, uint64_t flags) ret = vrf_if_ioctl(SIOCSIFFLAGS, (caddr_t)&ifreq, ifp->vrf->vrf_id); if (ret < 0) { - zlog_info("can't set interface flags"); + zlog_info("can't set interface %s(%u) flags %" PRIu64, + ifp->name, ifp->vrf->vrf_id, flags); return ret; } return 0; @@ -533,7 +536,8 @@ int if_unset_flags(struct interface *ifp, uint64_t flags) ret = vrf_if_ioctl(SIOCSIFFLAGS, (caddr_t)&ifreq, ifp->vrf->vrf_id); if (ret < 0) { - zlog_info("can't unset interface flags"); + zlog_warn("can't unset interface %s(%u) flags %" PRIu64, + ifp->name, ifp->vrf->vrf_id, flags); return ret; } return 0; |