diff options
| author | Donald Sharp <sharpd@nvidia.com> | 2021-06-24 12:23:33 -0400 |
|---|---|---|
| committer | Donald Sharp <sharpd@nvidia.com> | 2022-02-07 16:10:03 -0500 |
| commit | c6eee91f66956a14d73f6b2f2e43a792c854195a (patch) | |
| tree | b4888f423738147f30ac134df048766fdda1dfb3 /zebra/connected.c | |
| parent | 16cdf5ddbc5c92f0dc43d9243a60a7258c67e68d (diff) | |
zebra: Fix ships in the night issue
When using wait for install there exists situations where
zebra will issue several route change operations to the kernel
but end up in a state where we shouldn't be at the end
due to extra data being received. Example:
a) zebra receives from bgp a route change, installs sends the
route to the kernel.
b) zebra receives a route deletion from bgp, removes the
struct route entry and then sends to the kernel a deletion.
c) zebra receives an asynchronous notification that (a) succeeded
but we treat this as a new route.
This is the ships in the night problem. In this case if we receive
notification from the kernel about a route that we know nothing
about and we are not in startup and we are doing asic offload
then we can ignore this update.
Ticket: #2563300
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Diffstat (limited to 'zebra/connected.c')
| -rw-r--r-- | zebra/connected.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/zebra/connected.c b/zebra/connected.c index b261ddb791..4f4e8be34b 100644 --- a/zebra/connected.c +++ b/zebra/connected.c @@ -290,10 +290,12 @@ void connected_up(struct interface *ifp, struct connected *ifc) } rib_add(afi, SAFI_UNICAST, zvrf->vrf->vrf_id, ZEBRA_ROUTE_CONNECT, 0, - flags, &p, NULL, &nh, 0, zvrf->table_id, metric, 0, 0, 0); + flags, &p, NULL, &nh, 0, zvrf->table_id, metric, 0, 0, 0, + false); rib_add(afi, SAFI_MULTICAST, zvrf->vrf->vrf_id, ZEBRA_ROUTE_CONNECT, 0, - flags, &p, NULL, &nh, 0, zvrf->table_id, metric, 0, 0, 0); + flags, &p, NULL, &nh, 0, zvrf->table_id, metric, 0, 0, 0, + false); /* Schedule LSP forwarding entries for processing, if appropriate. */ if (zvrf->vrf->vrf_id == VRF_DEFAULT) { |