diff options
| author | Donald Sharp <sharpd@nvidia.com> | 2020-10-12 08:35:18 -0400 |
|---|---|---|
| committer | Donald Sharp <sharpd@nvidia.com> | 2020-10-12 08:35:18 -0400 |
| commit | 28ef0ee121aa93399d8684a59d6ca66ee07ade84 (patch) | |
| tree | 0ed63f8466ec87119c32a0af40e490aa89c6622d /watchfrr | |
| parent | 8b6b6b694d7c5ae8193e0c9a3907b9143df44a07 (diff) | |
*: Use proper semantics for turning off thread
We have this pattern in the code base:
if (thread)
THREAD_OFF(thread);
If we look at THREAD_OFF we check to see if thread
is non-null too. So we have a double check.
This is unnecessary. Convert to just using THREAD_OFF
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Diffstat (limited to 'watchfrr')
| -rw-r--r-- | watchfrr/watchfrr.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/watchfrr/watchfrr.c b/watchfrr/watchfrr.c index d1003ad5fa..af243f7ca5 100644 --- a/watchfrr/watchfrr.c +++ b/watchfrr/watchfrr.c @@ -585,8 +585,7 @@ static void restart_done(struct daemon *dmn) dmn->name, state_str[dmn->state]); return; } - if (dmn->t_wakeup) - THREAD_OFF(dmn->t_wakeup); + THREAD_OFF(dmn->t_wakeup); if (try_connect(dmn) < 0) SET_WAKEUP_DOWN(dmn); } |