summaryrefslogtreecommitdiff
path: root/vrrpd/vrrp_zebra.c
diff options
context:
space:
mode:
authorQuentin Young <qlyoung@cumulusnetworks.com>2019-02-19 22:36:34 +0000
committerQuentin Young <qlyoung@cumulusnetworks.com>2019-05-17 00:27:08 +0000
commit8bceffc7c2da33a670723967cf525ab734b124f4 (patch)
tree9dbdbc89313cf674fbcc5c02b386187a695c8cf4 /vrrpd/vrrp_zebra.c
parentb0ec34c8fd86dc68a969146e3474ae3117c5a156 (diff)
vrrpd: don't update interface addrs on ifup
Updating interface addresses on autoconfigured VRRP instances when we receive notification that an interface is up will cause us to delete that VRRP instance because Zebra deletes all interface addresses when an interfaces goes down so when it comes back up it has no addresses which causes us to delete the instance, then Zebra subsequently sends us the addresses which causes the instance to get recreated, however in a non-owner scenario this will merely cause us to start in Backup, wait a while, transition to Master, protodown off our interface, get an interface up notification, delete all our ip addresses, destroy ourselves, receive address notifications, recreate ourselves, reenter Backup and cycle through it all over again. So we just have to assume that no addresses went away since this interface was last up. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Diffstat (limited to 'vrrpd/vrrp_zebra.c')
-rw-r--r--vrrpd/vrrp_zebra.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/vrrpd/vrrp_zebra.c b/vrrpd/vrrp_zebra.c
index 7a68f1bbcd..223d61001e 100644
--- a/vrrpd/vrrp_zebra.c
+++ b/vrrpd/vrrp_zebra.c
@@ -54,9 +54,6 @@ static void vrrp_zebra_debug_if_dump_address(struct interface *ifp,
for (ALL_LIST_ELEMENTS_RO(ifp->connected, node, ifc)) {
struct prefix *p = ifc->address;
- if (p->family != AF_INET)
- continue;
-
DEBUGD(&vrrp_dbg_zebra, "%s: interface %s address %s %s", func,
ifp->name, inet_ntoa(p->u.prefix4),
CHECK_FLAG(ifc->flags, ZEBRA_IFA_SECONDARY) ? "secondary"