summaryrefslogtreecommitdiff
path: root/vrrpd/vrrp_packet.c
diff options
context:
space:
mode:
authorQuentin Young <qlyoung@cumulusnetworks.com>2019-03-14 15:43:22 +0000
committerQuentin Young <qlyoung@cumulusnetworks.com>2019-05-17 00:27:08 +0000
commite1a32d76375fb992d21be9b47742a7a3736dc1ca (patch)
treef02abcbb19fc665b810cce3c7c562f7626baebab /vrrpd/vrrp_packet.c
parent958b1487639ea67a5c2acefe8ac79fd118c9dba5 (diff)
vrrpd: make useless assert useful
Assert would always come back true due to improper placement. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Diffstat (limited to 'vrrpd/vrrp_packet.c')
-rw-r--r--vrrpd/vrrp_packet.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/vrrpd/vrrp_packet.c b/vrrpd/vrrp_packet.c
index 102750eafe..fcbea8f695 100644
--- a/vrrpd/vrrp_packet.c
+++ b/vrrpd/vrrp_packet.c
@@ -112,13 +112,14 @@ ssize_t vrrp_pkt_adver_build(struct vrrp_pkt **pkt, struct ipaddr *src,
size_t addrsz = 0;
assert(version >= 2 && version <= 3);
- assert(!(version == 2 && v6));
if (numip > 0) {
v6 = IS_IPADDR_V6(ips[0]);
addrsz = IPADDRSZ(ips[0]);
}
+ assert(!(version == 2 && v6));
+
size_t pktsize = VRRP_PKT_SIZE(v6 ? AF_INET6 : AF_INET, version, numip);
*pkt = XCALLOC(MTYPE_VRRP_PKT, pktsize);