diff options
| author | Renato Westphal <renato@opensourcerouting.org> | 2020-08-19 19:48:21 -0300 |
|---|---|---|
| committer | Renato Westphal <renato@opensourcerouting.org> | 2020-08-19 20:07:01 -0300 |
| commit | 77463bc8a30be0622b922f85634fd81bab1fca45 (patch) | |
| tree | a52c92b229045eb5a29ed454f0b29561cbd85e43 /staticd/static_vty.c | |
| parent | 54c1ad98026bbf16e79f8390664885001d7f6b2d (diff) | |
staticd: fix warning when creating routes without SR-TE colors
The SR-TE color YANG leaf is optional so it shouldn't be created
unconditionally (it doesn't have a default value).
Fixes warnings like this when routes are created without specifying
a SR-TE color:
STATIC: libyang: Invalid value "" in "srte-color" element.
(/frr-routing:routing/control-plane-protocols/control-plane-protocol[type='frr-s
taticd:staticd'][name='staticd'][vrf='default']/frr-staticd:staticd/route-list[p
refix='99.0.0.1/32'][afi-safi='frr-routing:ipv4-unicast']/path-list[distance='1'
]/frr-nexthops/nexthop[nh-type='ip4'][vrf='default'][gateway='192.168.1.2'][inte
rface='(null)']/srte-color)
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Diffstat (limited to 'staticd/static_vty.c')
| -rw-r--r-- | staticd/static_vty.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/staticd/static_vty.c b/staticd/static_vty.c index ba1a8f9a25..4763406934 100644 --- a/staticd/static_vty.c +++ b/staticd/static_vty.c @@ -257,8 +257,9 @@ static int static_route_leak(struct vty *vty, const char *svrf, strlcpy(ab_xpath, xpath_nexthop, sizeof(ab_xpath)); strlcat(ab_xpath, FRR_STATIC_ROUTE_NH_COLOR_XPATH, sizeof(ab_xpath)); - nb_cli_enqueue_change(vty, ab_xpath, NB_OP_MODIFY, - color_str); + if (color_str) + nb_cli_enqueue_change(vty, ab_xpath, + NB_OP_MODIFY, color_str); } if (label_str) { /* copy of label string (start) */ |