summaryrefslogtreecommitdiff
path: root/pimd/pim_tib.c
diff options
context:
space:
mode:
authorSai Gomathi N <nsaigomathi@vmware.com>2022-10-27 01:52:31 -0700
committerMergify <37929162+mergify[bot]@users.noreply.github.com>2022-10-27 17:05:03 +0000
commit08c02eaf7ba90654b4cd443670ede5eb8329447a (patch)
tree7d0659ee172e6922fd7f6061fb0e053d7688b82a /pimd/pim_tib.c
parent99267afe94eb286cf3f55db4244982022058096a (diff)
pimd: Unchecked return value
In tib_sg_oil_setup: Value returned from a function is not checked for errors before being used. If the function returns an error value, the error value may be mistaken for a normal value. Here, only the nexthop value is being used. So casted the return type to void. Coverity CID-1519816 Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com> (cherry picked from commit f13530f23a9ba73027f8f40b78eb81396afaa092)
Diffstat (limited to 'pimd/pim_tib.c')
-rw-r--r--pimd/pim_tib.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/pimd/pim_tib.c b/pimd/pim_tib.c
index 8f5de3e938..3455e30064 100644
--- a/pimd/pim_tib.c
+++ b/pimd/pim_tib.c
@@ -49,7 +49,8 @@ tib_sg_oil_setup(struct pim_instance *pim, pim_sgaddr sg, struct interface *oif)
if (up) {
memcpy(&nexthop, &up->rpf.source_nexthop,
sizeof(struct pim_nexthop));
- pim_ecmp_nexthop_lookup(pim, &nexthop, vif_source, &grp, 0);
+ (void)pim_ecmp_nexthop_lookup(pim, &nexthop, vif_source, &grp,
+ 0);
if (nexthop.interface)
input_iface_vif_index = pim_if_find_vifindex_by_ifindex(
pim, nexthop.interface->ifindex);