diff options
| author | Russ White <russ@riw.us> | 2020-03-24 10:08:29 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-24 10:08:29 -0400 |
| commit | a33ec5aeb5ea24ce6fedf4178de4a264a3138038 (patch) | |
| tree | 8087b91f0ca656580dd4e52af5c86d257ed12c41 /pimd/pim_pim.c | |
| parent | 5b299acd1fbb8e4a9abe9c35a7b35d5e9af2f170 (diff) | |
| parent | 23a2f90a0055c86b89a5e257d08ce5ecdd321baf (diff) | |
Merge pull request #6010 from sarav511/uni_jn_ig
pimd: Ignore PIM Join/Prune, Assert and Hello without all-pim-routers address as dest IP
Diffstat (limited to 'pimd/pim_pim.c')
| -rw-r--r-- | pimd/pim_pim.c | 27 |
1 files changed, 27 insertions, 0 deletions
diff --git a/pimd/pim_pim.c b/pimd/pim_pim.c index 8d7a921cf4..a76fbed203 100644 --- a/pimd/pim_pim.c +++ b/pimd/pim_pim.c @@ -137,6 +137,18 @@ void pim_sock_delete(struct interface *ifp, const char *delete_message) sock_close(ifp); } +/* For now check dst address for hello, assrt and join/prune is all pim rtr */ +static bool pim_pkt_dst_addr_ok(enum pim_msg_type type, in_addr_t addr) +{ + if ((type == PIM_MSG_TYPE_HELLO) || (type == PIM_MSG_TYPE_ASSERT) + || (type == PIM_MSG_TYPE_JOIN_PRUNE)) { + if (addr != qpim_all_pim_routers_addr.s_addr) + return false; + } + + return true; +} + int pim_pim_packet(struct interface *ifp, uint8_t *buf, size_t len) { struct ip *ip_hdr; @@ -237,6 +249,21 @@ int pim_pim_packet(struct interface *ifp, uint8_t *buf, size_t len) } } + if (!pim_pkt_dst_addr_ok(header->type, ip_hdr->ip_dst.s_addr)) { + char dst_str[INET_ADDRSTRLEN]; + char src_str[INET_ADDRSTRLEN]; + + pim_inet4_dump("<dst?>", ip_hdr->ip_dst, dst_str, + sizeof(dst_str)); + pim_inet4_dump("<src?>", ip_hdr->ip_src, src_str, + sizeof(src_str)); + zlog_warn( + "%s: Ignoring Pkt. Unexpected IP destination %s for %s (Expected: all_pim_routers_addr) from %s", + __func__, dst_str, pim_pim_msgtype2str(header->type), + src_str); + return -1; + } + switch (header->type) { case PIM_MSG_TYPE_HELLO: return pim_hello_recv(ifp, ip_hdr->ip_src, |