summaryrefslogtreecommitdiff
path: root/pimd/pim_msg.c
diff options
context:
space:
mode:
authorDonald Sharp <sharpd@cumulusnetworks.com>2018-07-25 14:37:30 -0400
committerDonald Sharp <sharpd@cumulusnetworks.com>2018-07-25 14:37:30 -0400
commitbe523269fdbdd87ff567507a1d09f564cee9ca14 (patch)
tree794e9e06441ff0dd75f1e9e5d84d3cf238f83258 /pimd/pim_msg.c
parent66bbedb0693cf6aa2b45316380638bedc1c09241 (diff)
pimd: RPT Prunes do not need to be figured for a *,G Prune
Packet sending in PIM is a two step process. 1) Gather data size of next G to be packed into a packet. 2) Write data After 1 we need to ensure that the next G to pack will actually fit in a packet. If it does not send what we've currently written and start a new packet to send. Because this was a 2 step process it is important to be consistent in what you think you have packed -vs- what you think you should. PIM has a bug where we were considering S,G RPT Prunes for a *,G even when the *,G was being pruned. This lead to a situation where we were figuring a write size of more data then what we actually wrote into a packet. This would leave a 8 byte whole of 0's in the packet due to the way we moved pointers around. Fix the code so that we do not attempt to consider S,G rpt prunes for a *,G prune when figuring out how much we should write in step 1. Ticket: CM-21644 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Diffstat (limited to 'pimd/pim_msg.c')
-rw-r--r--pimd/pim_msg.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/pimd/pim_msg.c b/pimd/pim_msg.c
index 5d4ddf14e8..63688f87e0 100644
--- a/pimd/pim_msg.c
+++ b/pimd/pim_msg.c
@@ -114,7 +114,7 @@ size_t pim_msg_get_jp_group_size(struct list *sources)
size += sizeof(struct pim_encoded_source_ipv4) * sources->count;
js = listgetdata(listhead(sources));
- if (js && js->up->sg.src.s_addr == INADDR_ANY) {
+ if (js && js->up->sg.src.s_addr == INADDR_ANY && js->is_join) {
struct pim_upstream *child, *up;
struct listnode *up_node;