diff options
| author | David Lamparter <equinox@opensourcerouting.org> | 2020-04-23 20:27:26 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-23 20:27:26 +0200 |
| commit | c334a16ef105b7b187943db177ed7623b01e79ba (patch) | |
| tree | 79aa1a7def3eadc711549e9b0e81a773ca5fa569 /pimd/pim_cmd.c | |
| parent | e17316e56ba830e1cab0c4f382af7676a7bf979a (diff) | |
| parent | 08808541857dc78edd5bfd70f776bfbe58b44051 (diff) | |
Merge pull request #6262 from qlyoung/remove-sprintf
Diffstat (limited to 'pimd/pim_cmd.c')
| -rw-r--r-- | pimd/pim_cmd.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/pimd/pim_cmd.c b/pimd/pim_cmd.c index f6af98598b..fe9b5e1beb 100644 --- a/pimd/pim_cmd.c +++ b/pimd/pim_cmd.c @@ -2510,10 +2510,12 @@ static void pim_show_upstream(struct pim_instance *pim, struct vty *vty, pim_upstream_state2brief_str(up->join_state, state_str, sizeof(state_str)); if (up->reg_state != PIM_REG_NOINFO) { char tmp_str[PIM_REG_STATE_STR_LEN]; + char tmp[sizeof(state_str) + 1]; - sprintf(state_str + strlen(state_str), ",%s", - pim_reg_state2brief_str(up->reg_state, tmp_str, - sizeof(tmp_str))); + snprintf(tmp, sizeof(tmp), ",%s", + pim_reg_state2brief_str(up->reg_state, tmp_str, + sizeof(tmp_str))); + strlcat(state_str, tmp, sizeof(state_str)); } if (uj) { |