diff options
| author | Donald Sharp <sharpd@cumulusnetworks.com> | 2021-03-22 10:22:25 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-03-22 10:22:25 -0400 |
| commit | 7bf7917cdec9407db3666147406aec75ae6828ed (patch) | |
| tree | 6a2ea8099be802614ba80dda7309184d2e1558a7 /pceplib/pcep_socket_comm_loop.c | |
| parent | cb39b2d4aa37d2068ffc842695b312c09b1e0d37 (diff) | |
| parent | 7ed8c4b1fd2cd46864271e44a9778caa31d367fd (diff) | |
Merge pull request #8303 from volta-networks/fix_coverity_pceplib
pceplib: Fixing coverity messages.
Diffstat (limited to 'pceplib/pcep_socket_comm_loop.c')
| -rw-r--r-- | pceplib/pcep_socket_comm_loop.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/pceplib/pcep_socket_comm_loop.c b/pceplib/pcep_socket_comm_loop.c index 8346c93025..d58409c4f3 100644 --- a/pceplib/pcep_socket_comm_loop.c +++ b/pceplib/pcep_socket_comm_loop.c @@ -26,6 +26,7 @@ #include <stddef.h> #include <string.h> #include <unistd.h> +#include <assert.h> #include "pcep_socket_comm_internals.h" #include "pcep_socket_comm_loop.h" @@ -129,6 +130,9 @@ int build_fd_sets(pcep_socket_comm_handle *socket_comm_handle) comm_session = (pcep_socket_comm_session *)node->data; if (comm_session->socket_fd > max_fd) { max_fd = comm_session->socket_fd; + } else if (comm_session->socket_fd < 0) { + pcep_log(LOG_ERR, "%s: Negative fd", __func__); + assert(comm_session->socket_fd > 0); } /*pcep_log(LOG_DEBUG, ld] socket_comm::build_fdSets set @@ -147,6 +151,9 @@ int build_fd_sets(pcep_socket_comm_handle *socket_comm_handle) comm_session = (pcep_socket_comm_session *)node->data; if (comm_session->socket_fd > max_fd) { max_fd = comm_session->socket_fd; + } else if (comm_session->socket_fd < 0) { + pcep_log(LOG_ERR, "%s: Negative fd", __func__); + assert(comm_session->socket_fd > 0); } /*pcep_log(LOG_DEBUG, "%s: [%ld] socket_comm::build_fdSets set |