Merge pull request #711 ("Coverity munging")

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

1 files changed, 5 insertions, 0 deletions

diff --git a/ospfclient/ospf_apiclient.c b/ospfclient/ospf_apiclient.c
index 0ebae087e3..3f3b5511a2 100644
--- a/ospfclient/ospf_apiclient.c
+++ b/ospfclient/ospf_apiclient.c
@@ -183,6 +183,7 @@ ospf_apiclient_connect (char *host, int syncport)
   fd1 = socket (AF_INET, SOCK_STREAM, 0);
   if (fd1 < 0)
     {
+      close (async_server_sock);
       fprintf (stderr,
 	       "ospf_apiclient_connect: creating sync socket failed\n");
       return NULL;
@@ -196,6 +197,7 @@ ospf_apiclient_connect (char *host, int syncport)
     {
       fprintf (stderr, "ospf_apiclient_connect: SO_REUSEADDR failed\n");
       close (fd1);
+      close (async_server_sock);
       return NULL;
     }
 
@@ -206,6 +208,7 @@ ospf_apiclient_connect (char *host, int syncport)
     {
       fprintf (stderr, "ospf_apiclient_connect: SO_REUSEPORT failed\n");
       close (fd1);
+      close (async_server_sock);
       return NULL;
     }
 #endif /* SO_REUSEPORT */
@@ -227,6 +230,7 @@ ospf_apiclient_connect (char *host, int syncport)
     {
       fprintf (stderr, "ospf_apiclient_connect: bind sync socket failed\n");
       close (fd1);
+      close (async_server_sock);
       return NULL;
     }
 
@@ -260,6 +264,7 @@ ospf_apiclient_connect (char *host, int syncport)
       fprintf (stderr, "ospf_apiclient_connect: accept async failed\n");
       close (async_server_sock);
       close (fd1);
+      close (fd2);
       return NULL;
     }