diff options
| author | Dave LeRoy <dleroy@labn.net> | 2024-06-05 12:10:11 -0700 |
|---|---|---|
| committer | Dave LeRoy <dleroy@labn.net> | 2024-06-10 16:39:21 -0700 |
| commit | b5540d326b82ca92ed88f9082fe0ed2433b09c27 (patch) | |
| tree | 3e82b5a8df280c7724bda5d3725b2fd4d5f9c1be /nhrpd/nhrp_interface.c | |
| parent | 51f070028692260ea19b5ef0f489c56de5683bbc (diff) | |
nhrpd: add cisco-authentication password support
Taking over this development from https://github.com/FRRouting/frr/pull/14788
This commit addresses 4 issues found in the previous PR
1) FRR would accept messages from a spoke without authentication when FRR NHRP had auth configured.
2) The error indication was not being sent in network byte order
3) The debug print in nhrp_connection_authorized was not correctly printing the received password
4) The addresses portion of the mandatory part of the error indication was invalid on the wire (confirmed in wireshark)
Signed-off-by: Dave LeRoy <dleroy@labn.net>
Co-authored-by: Volodymyr Huti <volodymyr.huti@gmail.com>
Diffstat (limited to 'nhrpd/nhrp_interface.c')
| -rw-r--r-- | nhrpd/nhrp_interface.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/nhrpd/nhrp_interface.c b/nhrpd/nhrp_interface.c index 7d0ab9762f..e81a2efbb6 100644 --- a/nhrpd/nhrp_interface.c +++ b/nhrpd/nhrp_interface.c @@ -99,6 +99,8 @@ static int nhrp_if_delete_hook(struct interface *ifp) free(nifp->ipsec_fallback_profile); if (nifp->source) free(nifp->source); + if (nifp->auth_token) + zbuf_free(nifp->auth_token); XFREE(MTYPE_NHRP_IF, ifp->info); return 0; |