diff options
| author | Igor Ryzhov <iryzhov@nfware.com> | 2024-02-03 01:15:46 +0200 |
|---|---|---|
| committer | Igor Ryzhov <iryzhov@nfware.com> | 2024-02-07 18:37:29 +0200 |
| commit | 2574f03a13d6fdd6580015c527c8d4b151579a70 (patch) | |
| tree | 358a7f5e7b0b573c0617c340c16f8752a46c1234 /lib/vty.h | |
| parent | 0db4d555e98f90da320a802be67b75757eb78abc (diff) | |
vtysh: remove resync workaround when exiting to config node
When exiting from a level below the config node, like `router rip`,
vtysh executes a resync by sending "end" and "conf term [file-lock]"
commands to all the daemons. As statet in the description comment, it's
done "in case one of the daemons is somewhere else". I don't think this
actually ever happens, but even if it is, it is a bug in a daemon that
needs to be fixed. This resync was okay before the introduction of
mgmtd, but now it unlocks and locks back the datastores during the
configuration reading process, which can lead to a failure which is
explained in the previous commit.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Diffstat (limited to 'lib/vty.h')
| -rw-r--r-- | lib/vty.h | 4 |
1 files changed, 0 insertions, 4 deletions
@@ -232,10 +232,6 @@ struct vty { uintptr_t mgmt_req_pending_data; bool mgmt_locked_candidate_ds; bool mgmt_locked_running_ds; - /* Need to track when we file-lock in vtysh to re-lock on end/conf t - * workaround - */ - bool vtysh_file_locked; }; static inline void vty_push_context(struct vty *vty, int node, uint64_t id) |