diff options
| author | Russ White <russ@riw.us> | 2017-06-19 21:52:10 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-06-19 21:52:10 -0400 |
| commit | a88bbcb8a03856a8c5e386b03c0797ea05f64454 (patch) | |
| tree | 5c405f14a806e9b1caf7904b0b3f70cce5e24dbd /lib/termtable.c | |
| parent | d368cd48b94cb9a22b9733200d8cfd94c71338ce (diff) | |
| parent | 94b989402f6a4f4ea00c3a044deb7d910c4e3f45 (diff) | |
Merge pull request #732 from qlyoung/coverity-memes
lib: termtable coverity warnings
Diffstat (limited to 'lib/termtable.c')
| -rw-r--r-- | lib/termtable.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/lib/termtable.c b/lib/termtable.c index fb16e5dba1..283fa173d8 100644 --- a/lib/termtable.c +++ b/lib/termtable.c @@ -123,15 +123,13 @@ static struct ttable_cell *ttable_insert_row_va(struct ttable *tt, int i, assert(i >= -1 && i < tt->nrows); char *res, *orig, *section; - const char *f; struct ttable_cell *row; int col = 0; int ncols = 0; /* count how many columns we have */ - f = format; - for (; f[ncols]; f[ncols] == '|' ? ncols++ : *f++) - ; + for (int i = 0; format[i]; i++) + ncols += !!(format[i] == '|'); ncols++; if (tt->ncols == 0) @@ -338,7 +336,7 @@ char *ttable_dump(struct ttable *tt, const char *newline) /* calculate number of lines en total */ nlines = tt->nrows; nlines += tt->style.border.top_on ? 1 : 0; - nlines += tt->style.border.bottom_on ? 1 : 1; // makes life easier + nlines += 1; // tt->style.border.bottom_on ? 1 : 1; makes life easier for (int i = 0; i < tt->nrows; i++) { /* if leftmost cell has top / bottom border, whole row does */ nlines += tt->table[i][0].style.border.top_on ? 1 : 0; |