diff options
| author | Rafael Zalamena <rzalamena@opensourcerouting.org> | 2019-10-01 15:52:51 -0300 |
|---|---|---|
| committer | Rafael Zalamena <rzalamena@opensourcerouting.org> | 2020-02-04 14:05:43 -0300 |
| commit | e324ef433ca611ddf8274015c0b36c8de1fb3075 (patch) | |
| tree | 17c40ba58c9e15d6b426d3378836d01bd9f49e4b /lib/routemap_cli.c | |
| parent | a162869ef0798ef98d756238c6b89108a69f5a5d (diff) | |
lib: add backward compatibility for route map
Allow old CLI users to still print their configuration without migrating
to northbound.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Diffstat (limited to 'lib/routemap_cli.c')
| -rw-r--r-- | lib/routemap_cli.c | 56 |
1 files changed, 55 insertions, 1 deletions
diff --git a/lib/routemap_cli.c b/lib/routemap_cli.c index 987693c961..7023710564 100644 --- a/lib/routemap_cli.c +++ b/lib/routemap_cli.c @@ -46,6 +46,9 @@ DEFPY_NOSH( ROUTE_MAP_OP_CMD_STR ROUTE_MAP_SEQUENCE_CMD_STR) { + struct route_map_index *rmi; + struct route_map *rm; + int action_type; char xpath_action[XPATH_MAXLEN + 64]; char xpath_index[XPATH_MAXLEN + 32]; char xpath[XPATH_MAXLEN]; @@ -63,9 +66,16 @@ DEFPY_NOSH( nb_cli_enqueue_change(vty, xpath_action, NB_OP_MODIFY, action); rv = nb_cli_apply_changes(vty, NULL); - if (rv == CMD_SUCCESS) + if (rv == CMD_SUCCESS) { VTY_PUSH_XPATH(RMAP_NODE, xpath_index); + /* Add support for non-migrated route map users. */ + rm = route_map_get(name); + action_type = (action[0] == 'p') ? RMAP_PERMIT : RMAP_DENY; + rmi = route_map_index_get(rm, action_type, sequence); + VTY_PUSH_CONTEXT(RMAP_NODE, rmi); + } + return rv; } @@ -105,11 +115,55 @@ DEFPY( void route_map_instance_show(struct vty *vty, struct lyd_node *dnode, bool show_defaults) { + const struct route_map_rule *rmr; + const struct route_map_index *rmi; const char *name = yang_dnode_get_string(dnode, "../name"); const char *action = yang_dnode_get_string(dnode, "./action"); const char *sequence = yang_dnode_get_string(dnode, "./sequence"); vty_out(vty, "route-map %s %s %s\n", name, action, sequence); + + rmi = nb_running_get_entry(dnode, NULL, false); + if (rmi == NULL) { + /* + * We can't have outdated rules if route map hasn't + * been created yet. + */ + return; + } + +#define SKIP_RULE(name) if (strcmp((name), rmr->cmd->str) == 0) continue + + /* Print route map `match` for old CLI users. */ + for (rmr = rmi->match_list.head; rmr; rmr = rmr->next) { + /* Skip all matches implemented by northbound. */ + SKIP_RULE("interface"); + SKIP_RULE("ip address"); + SKIP_RULE("ip address prefix-list"); + SKIP_RULE("ip next-hop"); + SKIP_RULE("ip next-hop prefix-list"); + SKIP_RULE("ip next-hop type"); + SKIP_RULE("ipv6 address"); + SKIP_RULE("ipv6 address prefix-list"); + SKIP_RULE("ipv6 next-hop type"); + SKIP_RULE("metric"); + SKIP_RULE("tag"); + + vty_out(vty, " match %s %s\n", rmr->cmd->str, + rmr->rule_str ? rmr->rule_str : ""); + } + + /* Print route map `set` for old CLI users. */ + for (rmr = rmi->set_list.head; rmr; rmr = rmr->next) { + /* Skip all sets implemented by northbound. */ + SKIP_RULE("metric"); + SKIP_RULE("tag"); + + vty_out(vty, " set %s %s\n", rmr->cmd->str, + rmr->rule_str ? rmr->rule_str : ""); + } + +#undef SKIP_RULE } void route_map_instance_show_end(struct vty *vty, struct lyd_node *dnode) |