lib: Avoid using assignments within checks

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

1 files changed, 9 insertions, 5 deletions

diff --git a/lib/ntop.c b/lib/ntop.c
index ccbf8793d3..1b2dd7a6d1 100644
--- a/lib/ntop.c
+++ b/lib/ntop.c
@@ -40,14 +40,18 @@ static inline void putbyte(uint8_t bytex, char **posx)
 	bool zero = false;
 	int byte = bytex, tmp, a, b;
 
-	if ((tmp = byte - 200) >= 0) {
+	tmp = byte - 200;
+	if (tmp >= 0) {
 		*pos++ = '2';
 		zero = true;
 		byte = tmp;
-	} else if ((tmp = byte - 100) >= 0) {
-		*pos++ = '1';
-		zero = true;
-		byte = tmp;
+	} else {
+		tmp = byte - 100;
+		if (tmp >= 0) {
+			*pos++ = '1';
+			zero = true;
+			byte = tmp;
+		}
 	}
 
 	/* make sure the compiler knows the value range of "byte" */