diff options
| author | Christian Hopps <chopps@labn.net> | 2023-06-18 16:19:54 -0400 |
|---|---|---|
| committer | Christian Hopps <chopps@labn.net> | 2023-06-19 00:13:28 -0400 |
| commit | df0173ceeb93572329b04f1bfc5a8925e60513e3 (patch) | |
| tree | 6b48aab9aafa50b106ffb7fa0aecd952dd0915b7 /lib/mgmt.proto | |
| parent | 04b4ede097c94f04cc1d14ce90ee82e35a63d670 (diff) | |
mgmtd: KISS the locking code
Move away from things like "lock if not locked" type code, require the
user has locked prior to geting to that point.
For now we warn if we are taking a lock we already had; however, this
should really be a failure point.
New requirements:
SETCFG -
not implicit commit - requires user has locked candidate DS and they
must unlock after
implicit commit - requires user has locked candidate and running DS
both locks will be unlocked on reply to the SETCFG
COMMITCFG -
requires user has locked candidate and running DS and they must unlock
after
rollback - this code now get both locks and then does an unlock and
early return thing on the adapter side. It needs to be un-special
cased in follow up work that would also include tests for this
functionality.
Signed-off-by: Christian Hopps <chopps@labn.net>
Diffstat (limited to 'lib/mgmt.proto')
| -rw-r--r-- | lib/mgmt.proto | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/mgmt.proto b/lib/mgmt.proto index 8a11ff0fa5..ac44eefd9e 100644 --- a/lib/mgmt.proto +++ b/lib/mgmt.proto @@ -243,7 +243,8 @@ message FeSetConfigReply { required DatastoreId ds_id = 2; required uint64 req_id = 3; required bool success = 4; - optional string error_if_any = 5; + required bool implicit_commit = 5; + optional string error_if_any = 6; } message FeCommitConfigReq { |