diff options
| author | Quentin Young <qlyoung@cumulusnetworks.com> | 2019-05-14 20:19:07 +0000 |
|---|---|---|
| committer | Quentin Young <qlyoung@cumulusnetworks.com> | 2019-05-14 21:23:08 +0000 |
| commit | d8b87afe7c5fcee9caaef7124d5bcd5f0c3af8a1 (patch) | |
| tree | ca07ea6097ec12120806ff4c7bd268b9fc063842 /lib/hash.c | |
| parent | ab78033d65dfcdbd5d1fe952193fc302b9843724 (diff) | |
lib: hashing functions should take const arguments
It doesn't make much sense for a hash function to modify its argument,
so const the hash input.
BGP does it in a couple places, those cast away the const. Not great but
not any worse than it was.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Diffstat (limited to 'lib/hash.c')
| -rw-r--r-- | lib/hash.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/hash.c b/lib/hash.c index 884c8f22af..fad7de5138 100644 --- a/lib/hash.c +++ b/lib/hash.c @@ -37,7 +37,7 @@ static pthread_mutex_t _hashes_mtx = PTHREAD_MUTEX_INITIALIZER; static struct list *_hashes; struct hash *hash_create_size(unsigned int size, - unsigned int (*hash_key)(void *), + unsigned int (*hash_key)(const void *), bool (*hash_cmp)(const void *, const void *), const char *name) { @@ -66,7 +66,7 @@ struct hash *hash_create_size(unsigned int size, return hash; } -struct hash *hash_create(unsigned int (*hash_key)(void *), +struct hash *hash_create(unsigned int (*hash_key)(const void *), bool (*hash_cmp)(const void *, const void *), const char *name) { |