summaryrefslogtreecommitdiff
path: root/lib/command_py.c
diff options
context:
space:
mode:
authorLouis Scalbert <louis.scalbert@6wind.com>2024-02-20 17:49:01 +0100
committerLouis Scalbert <louis.scalbert@6wind.com>2024-02-21 15:44:58 +0100
commit44e6e3868d7a1488447f2be446dbd7cb5a5559ce (patch)
tree696ecefd551f2c049fd72d3fe9205f0baef53ce0 /lib/command_py.c
parent5332e447d9c92b70ffd8966013bc4ee9384feade (diff)
zebra: fix crash if macvlan link in another netns
A macvlan interface can have its underlying link-interface in another namespace (aka. netns). However, by default, zebra does not know the interface from the other namespaces. It results in a crash the pointer to the link interface is NULL. > 6 0x0000559d77a329d3 in zebra_vxlan_macvlan_up (ifp=0x559d798b8e00) at /root/frr/zebra/zebra_vxlan.c:4676 > 4676 link_zif = link_ifp->info; > (gdb) list > 4671 struct interface *link_ifp, *link_if; > 4672 > 4673 zif = ifp->info; > 4674 assert(zif); > 4675 link_ifp = zif->link; > 4676 link_zif = link_ifp->info; > 4677 assert(link_zif); > 4678 > (gdb) p zif->link > $2 = (struct interface *) 0x0 > (gdb) p zif->link_ifindex > $3 = 15 Fix the crash by returning when the macvlan link-interface is in another namespace. No need to go further because any vxlan under the macvlan interface would not be accessible by zebra. Link: https://github.com/FRRouting/frr/issues/15370 Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Diffstat (limited to 'lib/command_py.c')
0 files changed, 0 insertions, 0 deletions