summaryrefslogtreecommitdiff
path: root/lib/command_py.c
diff options
context:
space:
mode:
authorChirag Shah <chirag@nvidia.com>2023-06-05 21:48:12 -0700
committerMergify <37929162+mergify[bot]@users.noreply.github.com>2023-06-07 06:23:54 +0000
commit03c65e7f7f94b0be052c98d942a5cdc8ee1d3cd6 (patch)
treeef99de602dcc28a9522eaa15429d7bd5d3ddbe28 /lib/command_py.c
parent7b78b57674f17399dffc40ff1c3e0236a8d5a965 (diff)
tools: fix list value remove in frr-reload
There might be a time element(s) from temporary list are removed more than once which leads to valueError in certain python3 version. commit-id 1543f58b5 did not handle valueError properly. This caused regression where prefix-list config leads to delete followed by add. The new fix should just pass the exception as value removal from list_to_add or list_to_del is best effort. This allows prefix-list config has no change then removes the lines from lines_to_del and lines_to_add properly. Ticket:#3490252 Testing: Configure prefix-list in frr.conf and perform multiple frr-reload. After first reload operatoin subsequent ones should not result in delete followed by add of the prefix-list but rather no-op operation. (Pdb) lines_to_add [(('ip prefix-list FOO permit 10.2.1.0/24',), None)] (Pdb) lines_to_del [(('ip prefix-list FOO seq 5 permit 10.2.1.0/24',), None), (('ip prefix-list FOO seq 10 permit 10.2.1.0/24',), None)] (Pdb) lines_to_del_to_del [(('ip prefix-list FOO seq 5 permit 10.2.1.0/24',), None), (('ip prefix-list FOO seq 10 permit 10.2.1.0/24',), None)] (Pdb) lines_to_add_to_del [(('ip prefix-list FOO permit 10.2.1.0/24',), None), (('ip prefix-list FOO permit 10.2.1.0/24',), None)] (Pdb) c > /usr/lib/frr/frr-reload.py(1562)ignore_delete_re_add_lines() -> return (lines_to_add, lines_to_del) (Pdb) lines_to_add [] (Pdb) lines_to_del [] Signed-off-by: Chirag Shah <chirag@nvidia.com> (cherry picked from commit 9845c09d61a7e509bfae369648cb5f9893455ac4)
Diffstat (limited to 'lib/command_py.c')
0 files changed, 0 insertions, 0 deletions