diff options
| author | Donatas Abraitis <donatas@opensourcerouting.org> | 2022-05-11 13:16:44 +0300 |
|---|---|---|
| committer | Donatas Abraitis <donatas@opensourcerouting.org> | 2022-05-11 14:08:47 +0300 |
| commit | 6006b807b1a84d31611173b837fafcd96ba9d692 (patch) | |
| tree | 08f25453328d8c408f1a8c658e4e6ef91005d4a7 /isisd/isis_pfpacket.c | |
| parent | f51eeb864bc821d92bd8e95670dde1258ed0747c (diff) | |
*: Properly use memset() when zeroing
Wrong: memset(&a, 0, sizeof(struct ...));
Good: memset(&a, 0, sizeof(a));
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Diffstat (limited to 'isisd/isis_pfpacket.c')
| -rw-r--r-- | isisd/isis_pfpacket.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/isisd/isis_pfpacket.c b/isisd/isis_pfpacket.c index d58cd1c5bc..a448e0043c 100644 --- a/isisd/isis_pfpacket.c +++ b/isisd/isis_pfpacket.c @@ -144,7 +144,7 @@ static int open_packet_socket(struct isis_circuit *circuit) /* * Bind to the physical interface */ - memset(&s_addr, 0, sizeof(struct sockaddr_ll)); + memset(&s_addr, 0, sizeof(s_addr)); s_addr.sll_family = AF_PACKET; s_addr.sll_protocol = htons(ETH_P_ALL); s_addr.sll_ifindex = circuit->interface->ifindex; @@ -233,7 +233,7 @@ int isis_recv_pdu_bcast(struct isis_circuit *circuit, uint8_t *ssnpa) addr_len = sizeof(s_addr); - memset(&s_addr, 0, sizeof(struct sockaddr_ll)); + memset(&s_addr, 0, sizeof(s_addr)); bytesread = recvfrom(circuit->fd, (void *)&llc, LLC_LEN, MSG_PEEK, @@ -306,7 +306,7 @@ int isis_recv_pdu_p2p(struct isis_circuit *circuit, uint8_t *ssnpa) int bytesread, addr_len; struct sockaddr_ll s_addr; - memset(&s_addr, 0, sizeof(struct sockaddr_ll)); + memset(&s_addr, 0, sizeof(s_addr)); addr_len = sizeof(s_addr); /* we can read directly to the stream */ @@ -351,7 +351,7 @@ int isis_send_pdu_bcast(struct isis_circuit *circuit, int level) struct sockaddr_ll sa; stream_set_getp(circuit->snd_stream, 0); - memset(&sa, 0, sizeof(struct sockaddr_ll)); + memset(&sa, 0, sizeof(sa)); sa.sll_family = AF_PACKET; size_t frame_size = stream_get_endp(circuit->snd_stream) + LLC_LEN; @@ -398,7 +398,7 @@ int isis_send_pdu_p2p(struct isis_circuit *circuit, int level) ssize_t rv; stream_set_getp(circuit->snd_stream, 0); - memset(&sa, 0, sizeof(struct sockaddr_ll)); + memset(&sa, 0, sizeof(sa)); sa.sll_family = AF_PACKET; sa.sll_ifindex = circuit->interface->ifindex; sa.sll_halen = ETH_ALEN; |