diff options
| author | Renato Westphal <renato@opensourcerouting.org> | 2020-10-23 21:05:30 -0300 |
|---|---|---|
| committer | Renato Westphal <renato@opensourcerouting.org> | 2020-11-04 17:12:30 -0300 |
| commit | 2f7cc7bcd3052a8687da8adffbed6aea5b71e90b (patch) | |
| tree | d2d3153d7097fcb121265b571f870fbaffd0947b /isisd/isis_errors.h | |
| parent | 28315916a2542052c7381d42900d6f16ed190c22 (diff) | |
isisd: detect Prefix-SID collisions and handle them appropriately
isisd relies on its YANG module to prevent the same SID index
from being configured multiple times for different prefixes. It's
possible, however, to have different routers assigning the same SID
index for different prefixes. When that happens, we say we have a
Prefix-SID collision, which is ultimately a misconfiguration issue.
The problem with Prefix-SID collisions is that the Prefix-SID that
is processed later overwrites the previous ones. Then, once the
Prefix-SID collision is fixed in the configuration, the overwritten
Prefix-SID isn't reinstalled since it's already marked as installed
and it didn't change. To prevent such inconsistency from happening,
add a safeguard in the SPF code to detect Prefix-SID collisions and
handle them appropriately (i.e. log a warning + ignore the Prefix-SID
Sub-TLV since it's already in use by another prefix). That way,
once the configuration is fixed, no Prefix-SID label entry will be
missing in the LFIB.
Reported-by: Emanuele Di Pascale <emanuele@voltanet.io>
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Diffstat (limited to 'isisd/isis_errors.h')
| -rw-r--r-- | isisd/isis_errors.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/isisd/isis_errors.h b/isisd/isis_errors.h index d5674dbf30..6f3e5f85cf 100644 --- a/isisd/isis_errors.h +++ b/isisd/isis_errors.h @@ -27,6 +27,7 @@ enum isis_log_refs { EC_ISIS_PACKET = ISIS_FERR_START, EC_ISIS_CONFIG, EC_ISIS_SID_OVERFLOW, + EC_ISIS_SID_COLLISION, }; extern void isis_error_init(void); |