summaryrefslogtreecommitdiff
path: root/doc/developer/workflow.rst
diff options
context:
space:
mode:
authorDavid Lamparter <equinox@opensourcerouting.org>2022-03-01 11:44:57 +0100
committerGitHub <noreply@github.com>2022-03-01 11:44:57 +0100
commit17dd5ca8f8e86bde0bb2fae9c8cf195c19bb9d13 (patch)
treee9a2b7d1b5e429542bb98d7e956aa382bf52fe46 /doc/developer/workflow.rst
parent145ce1825cf071771b68eb494a0d8ff3838398b8 (diff)
parent264274daed4b384f0d86f855fdc7be289006a893 (diff)
Merge pull request #10584 from donaldsharp/workflow_modification
Diffstat (limited to 'doc/developer/workflow.rst')
-rw-r--r--doc/developer/workflow.rst11
1 files changed, 9 insertions, 2 deletions
diff --git a/doc/developer/workflow.rst b/doc/developer/workflow.rst
index 45bee17b71..af8756a909 100644
--- a/doc/developer/workflow.rst
+++ b/doc/developer/workflow.rst
@@ -346,6 +346,13 @@ Pre-submission Checklist
the new feature within our existing CI infrastructure. Also the
addition of automated testing to cover any pull request is encouraged.
+- All new code must use the current latest version of acceptable code.
+
+ - If a daemon is converted to YANG, then new code must use YANG.
+ - DEFPY's must be used for new cli
+ - Typesafe lists must be used
+ - printf formatting changes must be used
+
.. _signing-off:
Signing Off
@@ -1250,8 +1257,8 @@ CLI changes
-----------
CLI's are a complicated ugly beast. Additions or changes to the CLI should use
-a DEFUN to encapsulate one setting as much as is possible. Additionally as new
-DEFUN's are added to the system, documentation should be provided for the new
+a DEFPY to encapsulate one setting as much as is possible. Additionally as new
+DEFPY's are added to the system, documentation should be provided for the new
commands.
Backwards Compatibility