diff options
| author | Quentin Young <qlyoung@cumulusnetworks.com> | 2018-03-30 15:52:12 -0400 |
|---|---|---|
| committer | Quentin Young <qlyoung@cumulusnetworks.com> | 2018-04-02 16:03:11 -0400 |
| commit | ef7eec745d66fde824ebf4274bdf5055353e20cb (patch) | |
| tree | 684d153caa2b0c1013c78cea6537307be37f4c2a /bgpd/rfapi/vnc_debug.c | |
| parent | b755fd3530f05f243d18d91206746f69788a6c9a (diff) | |
bgpd, pim: remove undebug
This 'undebug' syntax is only used in 5 commands and serves no apparent
purpose.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Diffstat (limited to 'bgpd/rfapi/vnc_debug.c')
| -rw-r--r-- | bgpd/rfapi/vnc_debug.c | 41 |
1 files changed, 34 insertions, 7 deletions
diff --git a/bgpd/rfapi/vnc_debug.c b/bgpd/rfapi/vnc_debug.c index 3e9b5ed6b9..2b08ea493c 100644 --- a/bgpd/rfapi/vnc_debug.c +++ b/bgpd/rfapi/vnc_debug.c @@ -85,10 +85,9 @@ DEFUN (debug_bgp_vnc, DEFUN (no_debug_bgp_vnc, no_debug_bgp_vnc_cmd, - "<no debug|undebug> bgp vnc <rfapi-query|import-bi-attach|import-del-remote|verbose>", + "no debug bgp vnc <rfapi-query|import-bi-attach|import-del-remote|verbose>", NO_STR DEBUG_STR - "Undebug\n" BGP_STR VNC_STR "rfapi query handling\n" @@ -98,10 +97,8 @@ DEFUN (no_debug_bgp_vnc, { size_t i; - if (strmatch(argv[0]->text, "no")) - argc--, argv++; for (i = 0; i < (sizeof(vncdebug) / sizeof(struct vnc_debug)); ++i) { - if (strmatch(argv[3]->text, vncdebug[i].name)) { + if (strmatch(argv[argc - 1]->text, vncdebug[i].name)) { if (vty->node == CONFIG_NODE) { conf_vnc_debug &= ~vncdebug[i].bit; term_vnc_debug &= ~vncdebug[i].bit; @@ -117,6 +114,20 @@ DEFUN (no_debug_bgp_vnc, return CMD_WARNING_CONFIG_FAILED; } +#if CONFDATE > 20190402 +CPP_NOTICE("bgpd: time to remove undebug commands") +#endif +ALIAS_HIDDEN(no_debug_bgp_vnc, + undebug_bgp_vnc_cmd, + "undebug bgp vnc <rfapi-query|import-bi-attach|import-del-remote|verbose>", + "Undebug\n" + BGP_STR + VNC_STR + "rfapi query handling\n" + "import BI atachment\n" + "import delete remote routes\n" + "verbose logging\n") + /*********************************************************************** * no debug bgp vnc all @@ -124,10 +135,9 @@ DEFUN (no_debug_bgp_vnc, DEFUN (no_debug_bgp_vnc_all, no_debug_bgp_vnc_all_cmd, - "<no debug|undebug> all bgp vnc", + "no debug all bgp vnc", NO_STR DEBUG_STR - "Undebug command\n" "Disable all VNC debugging\n" BGP_STR VNC_STR) @@ -138,6 +148,17 @@ DEFUN (no_debug_bgp_vnc_all, return CMD_SUCCESS; } +#if CONFDATE > 20190402 +CPP_NOTICE("bgpd: time to remove undebug commands") +#endif +ALIAS_HIDDEN (no_debug_bgp_vnc_all, + undebug_bgp_vnc_all_cmd, + "undebug all bgp vnc", + "Undebug\n" + "Disable all VNC debugging\n" + BGP_STR + VNC_STR) + /*********************************************************************** * show/save ***********************************************************************/ @@ -188,6 +209,12 @@ void vnc_debug_init(void) install_element(ENABLE_NODE, &debug_bgp_vnc_cmd); install_element(CONFIG_NODE, &debug_bgp_vnc_cmd); install_element(ENABLE_NODE, &no_debug_bgp_vnc_cmd); + install_element(CONFIG_NODE, &no_debug_bgp_vnc_cmd); + install_element(ENABLE_NODE, &undebug_bgp_vnc_cmd); + install_element(CONFIG_NODE, &undebug_bgp_vnc_cmd); install_element(ENABLE_NODE, &no_debug_bgp_vnc_all_cmd); + install_element(CONFIG_NODE, &no_debug_bgp_vnc_all_cmd); + install_element(ENABLE_NODE, &undebug_bgp_vnc_all_cmd); + install_element(CONFIG_NODE, &undebug_bgp_vnc_all_cmd); } |