summaryrefslogtreecommitdiff
path: root/bgpd/bgp_routemap.c
diff options
context:
space:
mode:
authorDonatas Abraitis <donatas@opensourcerouting.org>2023-02-17 18:28:17 +0200
committerDonatas Abraitis <donatas@opensourcerouting.org>2023-02-17 18:53:01 +0200
commit81a57d81812115bdbab25168e86e509e2db607a1 (patch)
treec3b8ccb821d3352d88d5741c4f016ba54690df0a /bgpd/bgp_routemap.c
parent8383d53e43dfe7313783700bc2ed0ec823224bf1 (diff)
bgpd: Deprecate BGP `internet` community
Quite a few well-known communities from IANA's list do not receive special treatment in Cisco IOS XR, and at least one community on Cisco IOS XR's special treatment list, internet == 0:0, is not formally a well-known community as it is not in [IANA-WKC] (it is taken from the Reserved range [0x00000000-0x0000FFFF]). https://datatracker.ietf.org/doc/html/rfc8642 This is Cisco-specific command which is causing lots of questions when it comes to debugging and/or configuring it properly, but overall, this behavior is very odd and it's not clear how it should be treated between different vendor implementations. Let's deprecate it and let the operators use 0:0/0 communities as they want. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Diffstat (limited to 'bgpd/bgp_routemap.c')
-rw-r--r--bgpd/bgp_routemap.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/bgpd/bgp_routemap.c b/bgpd/bgp_routemap.c
index f9def03693..873884ba54 100644
--- a/bgpd/bgp_routemap.c
+++ b/bgpd/bgp_routemap.c
@@ -5870,9 +5870,14 @@ DEFUN_YANG (set_community,
else
first = 1;
+#if CONFDATE > 20230801
+CPP_NOTICE("Deprecate COMMUNITY_INTERNET BGP community")
+#endif
if (strncmp(argv[i]->arg, "internet", strlen(argv[i]->arg))
== 0) {
buffer_putstr(b, "internet");
+ vty_out(vty, "%% `internet` community is deprecated\n");
+ zlog_warn("`internet` community is deprecated");
continue;
}
if (strncmp(argv[i]->arg, "local-AS", strlen(argv[i]->arg))