diff options
| author | Donatas Abraitis <donatas@opensourcerouting.org> | 2022-05-11 13:16:44 +0300 | 
|---|---|---|
| committer | Donatas Abraitis <donatas@opensourcerouting.org> | 2022-05-11 14:08:47 +0300 | 
| commit | 6006b807b1a84d31611173b837fafcd96ba9d692 (patch) | |
| tree | 08f25453328d8c408f1a8c658e4e6ef91005d4a7 /bgpd/bgp_flowspec_util.c | |
| parent | f51eeb864bc821d92bd8e95670dde1258ed0747c (diff) | |
*: Properly use memset() when zeroing
    Wrong: memset(&a, 0, sizeof(struct ...));
    Good:  memset(&a, 0, sizeof(a));
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Diffstat (limited to 'bgpd/bgp_flowspec_util.c')
| -rw-r--r-- | bgpd/bgp_flowspec_util.c | 6 | 
1 files changed, 3 insertions, 3 deletions
diff --git a/bgpd/bgp_flowspec_util.c b/bgpd/bgp_flowspec_util.c index 348dc7c9d1..9f3ea499ff 100644 --- a/bgpd/bgp_flowspec_util.c +++ b/bgpd/bgp_flowspec_util.c @@ -97,7 +97,7 @@ bool bgp_flowspec_contains_prefix(const struct prefix *pfs,  		switch (type) {  		case FLOWSPEC_DEST_PREFIX:  		case FLOWSPEC_SRC_PREFIX: -			memset(&compare, 0, sizeof(struct prefix)); +			memset(&compare, 0, sizeof(compare));  			ret = bgp_flowspec_ip_address(  					BGP_FLOWSPEC_CONVERT_TO_NON_OPAQUE,  					nlri_content+offset, @@ -185,7 +185,7 @@ int bgp_flowspec_ip_address(enum bgp_flowspec_util_nlri_t type,  	uint8_t prefix_offset = 0;  	*error = 0; -	memset(&prefix_local, 0, sizeof(struct prefix)); +	memset(&prefix_local, 0, sizeof(prefix_local));  	/* read the prefix length */  	prefix_local.prefixlen = nlri_ptr[offset];  	psize = PSIZE(prefix_local.prefixlen); @@ -665,7 +665,7 @@ bool bgp_flowspec_get_first_nh(struct bgp *bgp, struct bgp_path_info *pi,  	struct bgp_dest *dest = pi->net;  	struct bgp_pbr_entry_action *api_action; -	memset(&api, 0, sizeof(struct bgp_pbr_entry_main)); +	memset(&api, 0, sizeof(api));  	if (bgp_pbr_build_and_validate_entry(bgp_dest_get_prefix(dest), pi,  					     &api)  	    < 0)  | 
