diff options
| author | Louis Scalbert <louis.scalbert@6wind.com> | 2023-09-28 15:08:23 +0200 |
|---|---|---|
| committer | Louis Scalbert <louis.scalbert@6wind.com> | 2023-09-28 15:08:23 +0200 |
| commit | eb9e2865116777661c44963769c1a5fed764b7f9 (patch) | |
| tree | c0bd00fee1518392956c318bbc4e97c1bc9bb709 /bgpd/bgp_attr.c | |
| parent | 8640fc9c0a5e6118fe878970169b38ddc00e8390 (diff) | |
bgpd: do not check attr in bgp_packet_attribute
Fix the following coverity issue. attr cannot be NULL.
> CID 1568376 (#1 of 1): Dereference before null check (REVERSE_INULL)
> check_after_deref: Null-checking attr suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
Fixes: 8b531b1107 ("bgpd: store and send bgp link-state attributes")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Diffstat (limited to 'bgpd/bgp_attr.c')
| -rw-r--r-- | bgpd/bgp_attr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c index cc7afbe74f..05cf63e053 100644 --- a/bgpd/bgp_attr.c +++ b/bgpd/bgp_attr.c @@ -4982,7 +4982,7 @@ bgp_size_t bgp_packet_attribute(struct bgp *bgp, struct peer *peer, } /* BGP Link-State */ - if (attr && attr->link_state) { + if (attr->link_state) { stream_putc(s, BGP_ATTR_FLAG_OPTIONAL); stream_putc(s, BGP_ATTR_LINK_STATE); stream_putc(s, attr->link_state->length); |