diff options
| author | Donald Sharp <donaldsharp72@gmail.com> | 2025-03-06 20:32:39 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-03-06 20:32:39 -0500 |
| commit | aa86d77e4501cd0f4ee51811a38326a20fe45ae9 (patch) | |
| tree | 557847e38e241108f4fb54a2ea855d673879d543 | |
| parent | 9ffd44779b9dd3972f48397c87c18e1f7f6ca21d (diff) | |
| parent | 3802a0b709fb167579bdf4471bd64fdd6eea6db0 (diff) | |
Merge pull request #18333 from FRRouting/mergify/bp/stable/10.2/pr-18315
pimd: Fix PIM6 MLD VRF support (use recvmsg() pktinfo) (backport #18315)
| -rw-r--r-- | pimd/pim6_mld.c | 27 |
1 files changed, 15 insertions, 12 deletions
diff --git a/pimd/pim6_mld.c b/pimd/pim6_mld.c index a871837701..af9abeb3af 100644 --- a/pimd/pim6_mld.c +++ b/pimd/pim6_mld.c @@ -1657,18 +1657,6 @@ static void gm_t_recv(struct event *t) goto out_free; } - struct interface *ifp; - - ifp = if_lookup_by_index(pkt_src->sin6_scope_id, pim->vrf->vrf_id); - if (!ifp || !ifp->info) - goto out_free; - - struct pim_interface *pim_ifp = ifp->info; - struct gm_if *gm_ifp = pim_ifp->mld; - - if (!gm_ifp) - goto out_free; - for (cmsg = CMSG_FIRSTHDR(mh); cmsg; cmsg = CMSG_NXTHDR(mh, cmsg)) { if (cmsg->cmsg_level != SOL_IPV6) continue; @@ -1687,6 +1675,21 @@ static void gm_t_recv(struct event *t) } } + /* Prefer pktinfo as that also works in case of VRF */ + ifindex_t ifindex = pktinfo ? pktinfo->ipi6_ifindex + : pkt_src->sin6_scope_id; + struct interface *ifp; + + ifp = if_lookup_by_index(ifindex, pim->vrf->vrf_id); + if (!ifp || !ifp->info) + goto out_free; + + struct pim_interface *pim_ifp = ifp->info; + struct gm_if *gm_ifp = pim_ifp->mld; + + if (!gm_ifp) + goto out_free; + if (!pktinfo || !hoplimit) { zlog_err(log_ifp( "BUG: packet without IPV6_PKTINFO or IPV6_HOPLIMIT")); |
