summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLouis Scalbert <louis.scalbert@6wind.com>2025-04-16 11:23:54 +0200
committerMergify <37929162+mergify[bot]@users.noreply.github.com>2025-04-16 11:51:09 +0000
commite31d3b8cd929e61f5321d83317b703d6e2ca1b3b (patch)
tree5e1d4becd8a069bde479e5c6a3477a7aeb96901a
parentcc8a1f53a0bdf7acbb659d3abae155b7931c7bb0 (diff)
isisd: fix srv6_sid memory leak
Seen with isis_srv6_topo1 topotest. > ==178793==ERROR: LeakSanitizer: detected memory leaks > > Direct leak of 56 byte(s) in 1 object(s) allocated from: > #0 0x7f3f63cb4a57 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154 > #1 0x7f3f6366f8dd in qcalloc lib/memory.c:105 > #2 0x561b810c62b7 in isis_srv6_sid_alloc isisd/isis_srv6.c:243 > #3 0x561b8111f944 in isis_zebra_srv6_sid_notify isisd/isis_zebra.c:1534 > #4 0x7f3f637df9d7 in zclient_read lib/zclient.c:4845 > #5 0x7f3f637779b2 in event_call lib/event.c:2011 > #6 0x7f3f63642ff1 in frr_run lib/libfrr.c:1216 > #7 0x561b81018bf2 in main isisd/isis_main.c:360 > #8 0x7f3f63029d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 Fixes: 0af0f4616d ("isisd: Receive SRv6 SIDs notifications from zebra") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com> (cherry picked from commit 25c813ac382ba79270f40b85e168cdbcad499e2d)
-rw-r--r--isisd/isis_zebra.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/isisd/isis_zebra.c b/isisd/isis_zebra.c
index b985ad1f7d..b8baca19be 100644
--- a/isisd/isis_zebra.c
+++ b/isisd/isis_zebra.c
@@ -1501,6 +1501,7 @@ static int isis_zebra_srv6_sid_notify(ZAPI_CALLBACK_ARGS)
isis_zebra_srv6_sid_uninstall(area, sid);
listnode_delete(area->srv6db.srv6_sids,
sid);
+ isis_srv6_sid_free(sid);
}
/* Allocate new SRv6 End SID */