diff options
| author | Tuetuopay <tuetuopay@me.com> | 2025-03-14 20:21:46 +0100 |
|---|---|---|
| committer | Donatas Abraitis <donatas@opensourcerouting.org> | 2025-03-23 12:45:39 +0200 |
| commit | 8737b003d9755c828f522567d36ea7a49e3bd99e (patch) | |
| tree | 2d0c508872a28c1d21d68193b84e1279cbff255e | |
| parent | fcbace3d7ea49a378bd6110bee0150ab79f6247d (diff) | |
bgpd: fix `set evpn gateway-ip ipv[46]` route-map
The `route_set_evpn_gateway_ip` function copies `gw_ip->ip.addr` in the
route's gateway ip. In a nutshell, this skips the `ipa_type` field,
writing the actual IP in the IP type. This later rightfully trips
asserts about unknown IP types.
The following route-map...
```
route-map test permit 10
set evpn gateway-ip ipv4 1.1.1.1
```
...will make the following gateway IP in the route:
```
(gdb) p/x a1->evpn_overlay->gw_ip
$11 = {ipa_type = 0x1010101, ip = {addr = 0x0, addrbytes = {
0x0 <repeats 16 times>}, _v4_addr = {s_addr = 0x0}, _v6_addr = {
__in6_u = {__u6_addr8 = {0x0 <repeats 16 times>}, __u6_addr16 = {0x0,
0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, __u6_addr32 = {0x0, 0x0, 0x0,
0x0}}}}}
```
We do indeed see the IP Address in the `ipa_type` field.
Fix by starting the memcpy at the root of `struct ipaddr` instead of
skipping the `ipa_type` field.
Fixes: d0a4ee6010a ("bgpd: Add "set evpn gateway-ip" clause for route-map")
Signed-off-by: Tuetuopay <tuetuopay@me.com>
(cherry picked from commit 0b0e7015971a788c14dd1dc9b5bac8cb66175c29)
| -rw-r--r-- | bgpd/bgp_routemap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bgpd/bgp_routemap.c b/bgpd/bgp_routemap.c index 7a96f0cf6e..548726549f 100644 --- a/bgpd/bgp_routemap.c +++ b/bgpd/bgp_routemap.c @@ -1254,7 +1254,7 @@ route_set_evpn_gateway_ip(void *rule, const struct prefix *prefix, void *object) /* Set gateway-ip value. */ bre->type = OVERLAY_INDEX_GATEWAY_IP; - memcpy(&bre->gw_ip, &gw_ip->ip.addr, IPADDRSZ(gw_ip)); + bre->gw_ip = *gw_ip; bgp_attr_set_evpn_overlay(path->attr, bre); return RMAP_OKAY; |