diff options
| author | Donald Sharp <sharpd@cumulusnetworks.com> | 2017-12-14 12:24:52 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-12-14 12:24:52 -0500 |
| commit | fe15e7a61d4f9ced6bb23db303f29e25adebf290 (patch) | |
| tree | d4e9a8a74df7032f133e915285e1d1962c236558 | |
| parent | b9bd2646243bcbd78029a11d5ad6584ea7b1485c (diff) | |
| parent | 1ad057aed6a16ba85ef5a770f7855d749ed94881 (diff) | |
Merge pull request #1554 from opensourcerouting/cover-fix1
bgpd: fix some coverity scan issues
| -rw-r--r-- | bgpd/rfapi/bgp_rfapi_cfg.c | 12 | ||||
| -rw-r--r-- | bgpd/rfapi/rfapi_vty.c | 2 |
2 files changed, 11 insertions, 3 deletions
diff --git a/bgpd/rfapi/bgp_rfapi_cfg.c b/bgpd/rfapi/bgp_rfapi_cfg.c index 3fbba66774..7f2dbe7f9d 100644 --- a/bgpd/rfapi/bgp_rfapi_cfg.c +++ b/bgpd/rfapi/bgp_rfapi_cfg.c @@ -1626,7 +1626,11 @@ DEFUN (vnc_nve_group_export_no_prefixlist, return CMD_WARNING_CONFIG_FAILED; } - argv_find_and_parse_afi(argv, argc, &idx, &afi); + if (!argv_find_and_parse_afi(argv, argc, &idx, &afi)) { + vty_out(vty, "%% Malformed Address Family\n"); + return CMD_WARNING_CONFIG_FAILED; + } + if (argv[idx-1]->text[0] == 'z') is_bgp = 0; idx += 2; /* skip afi and keyword */ @@ -1691,7 +1695,11 @@ DEFUN (vnc_nve_group_export_prefixlist, return CMD_WARNING_CONFIG_FAILED; } - argv_find_and_parse_afi(argv, argc, &idx, &afi); + if (!argv_find_and_parse_afi(argv, argc, &idx, &afi)) { + vty_out(vty, "%% Malformed Address Family\n"); + return CMD_WARNING_CONFIG_FAILED; + } + if (argv[idx-1]->text[0] == 'z') is_bgp = 0; idx = argc - 1; diff --git a/bgpd/rfapi/rfapi_vty.c b/bgpd/rfapi/rfapi_vty.c index fb7d8beab3..37ca5edc96 100644 --- a/bgpd/rfapi/rfapi_vty.c +++ b/bgpd/rfapi/rfapi_vty.c @@ -1529,7 +1529,7 @@ void rfapiPrintRd(struct vty *vty, struct prefix_rd *prd) { char buf[RD_ADDRSTRLEN]; - prefix_rd2str(prd, buf, BUFSIZ); + prefix_rd2str(prd, buf, sizeof(buf)); vty_out(vty, "%s", buf); } |