diff options
| author | Martin Winter <mwinter@opensourcerouting.org> | 2018-04-03 15:54:27 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-04-03 15:54:27 +0100 |
| commit | a329ad23cf742b3701e0f7016522f86f0814f9ee (patch) | |
| tree | d58f54419153188db6452378ba2e899eda02d643 | |
| parent | 5012c1b6eed36e67dc8ee32488f3c396bf7b738b (diff) | |
| parent | 22265b3584a33eed88bc24261dcc2f20eed8d40a (diff) | |
Merge pull request #1882 from LabNConsulting/working/master/community-dismiss
workflow.rst: add note that author's shouldn't delete a comment or review
| -rw-r--r-- | doc/developer/workflow.rst | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/doc/developer/workflow.rst b/doc/developer/workflow.rst index 80029cbd1c..a6a950f685 100644 --- a/doc/developer/workflow.rst +++ b/doc/developer/workflow.rst @@ -256,7 +256,15 @@ After submitting your changes - Wait for reviewers. Someone will review your code or be assigned to review your code. - - Respond to any comments or concerns the reviewer has. + - Respond to any comments or concerns the reviewer has. Use e-mail or + add a comment via github to respond or to let the reviewer know how + their comment or concern is addressed. + - An author must never delete or manually dismiss someone else's comments + or review. (A review may be overridden by agreement in the weekly + technical meeting.) + - Automatically generated comments, e.g., those generated by CI systems, + may be deleted by authors and others when such comments are not the most + recent results from that automated comment source. - After all comments and concerns are addressed, expect your patch to be merged. |