diff options
| author | Rafael Zalamena <rzalamena@opensourcerouting.org> | 2023-01-19 10:32:18 -0300 |
|---|---|---|
| committer | Rafael Zalamena <rzalamena@opensourcerouting.org> | 2023-01-19 10:32:18 -0300 |
| commit | ab80e474f26f2e982bc15dd2506ff2eeef129dcc (patch) | |
| tree | b748ef3e047a81da272d210dc9f875a7b3a707f0 | |
| parent | 69306c44e817694f6a8acf530725f84ec59d1a33 (diff) | |
zebra: fix possible null dereference
Don't attempt to dereference `ifp` directly if it might be null: there
is a check right before this usage: `ifp ? ifp->info : NULL`.
In this context it should be safe to assume `ifp` is not NULL because
the only caller of this function checks that for this `ifindex`. For
consistency we'll check for null anyway in case this ever changes (and
with this the coverity scan warning gets silenced).
Found by Coverity Scan (CID 1519776)
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
| -rw-r--r-- | zebra/interface.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/zebra/interface.c b/zebra/interface.c index 87bb49042a..59563834ef 100644 --- a/zebra/interface.c +++ b/zebra/interface.c @@ -1436,7 +1436,8 @@ static void zebra_if_netconf_update_ctx(struct zebra_dplane_ctx *ctx, if (IS_ZEBRA_DEBUG_KERNEL) zlog_debug( "%s: if %s(%u) zebra info pointer is NULL", - __func__, ifp->name, ifp->ifindex); + __func__, ifp ? ifp->name : "(null)", + ifp ? ifp->ifindex : ifindex); return; } if (afi == AFI_IP) { |