diff options
| author | Patrick Ruddy <pat@voltanet.io> | 2020-10-13 11:48:37 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-10-13 11:48:37 +0100 |
| commit | d2a516dc7a53a90b401efdd7ecf9fb95d57b2548 (patch) | |
| tree | 63513e006e599b4bb8dc7200057e56d9cff87ef7 | |
| parent | 451171c09dbfa0b784193c5ee6a47e3055af4cf5 (diff) | |
| parent | 8ced966f398123108ad706825caf3ab85bc8b3b0 (diff) | |
Merge pull request #7279 from donaldsharp/17_coverity
17 coverity
| -rw-r--r-- | ospfd/ospf_network.c | 2 | ||||
| -rw-r--r-- | ripngd/ripng_nb_config.c | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/ospfd/ospf_network.c b/ospfd/ospf_network.c index 3a1547978a..28aec41eba 100644 --- a/ospfd/ospf_network.c +++ b/ospfd/ospf_network.c @@ -201,7 +201,6 @@ int ospf_sock_init(struct ospf *ospf) flog_err(EC_LIB_SOCKET, "Can't set IP_HDRINCL option for fd %d: %s", ospf_sock, safe_strerror(errno)); - close(ospf_sock); break; } #elif defined(IPTOS_PREC_INTERNETCONTROL) @@ -213,7 +212,6 @@ int ospf_sock_init(struct ospf *ospf) flog_err(EC_LIB_SOCKET, "can't set sockopt IP_TOS %d to socket %d: %s", tos, ospf_sock, safe_strerror(errno)); - close(ospf_sock); /* Prevent sd leak. */ break; } #else /* !IPTOS_PREC_INTERNETCONTROL */ diff --git a/ripngd/ripng_nb_config.c b/ripngd/ripng_nb_config.c index 85f378bc9e..25bf65f7aa 100644 --- a/ripngd/ripng_nb_config.c +++ b/ripngd/ripng_nb_config.c @@ -163,7 +163,7 @@ int ripngd_instance_default_information_originate_modify( ripng = nb_running_get_entry(args->dnode, NULL, true); default_information = yang_dnode_get_bool(args->dnode, NULL); - str2prefix_ipv6("::/0", &p); + (void)str2prefix_ipv6("::/0", &p); if (default_information) { ripng_redistribute_add(ripng, ZEBRA_ROUTE_RIPNG, RIPNG_ROUTE_DEFAULT, &p, 0, NULL, 0); |