summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Franke <chris@opensourcerouting.org>2017-10-02 16:01:58 +0200
committerChristian Franke <chris@opensourcerouting.org>2017-10-02 16:03:11 +0200
commit60d3914270ff0ad3de8c6c08cec8ca60f18cf84a (patch)
tree5276fff552c3d3a542ba21d961575d4bd19007c7
parentf5129394ecdb0e2c30e280b577f815f612ab1fe0 (diff)
isisd: fix vertex queue comparator
While vertizes should be strictly ordered on insertion, deletion will of course encouter equality. Signed-off-by: Christian Franke <chris@opensourcerouting.org>
-rw-r--r--isisd/isis_spf.c2
-rw-r--r--tests/isisd/test_isis_vertex_queue.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/isisd/isis_spf.c b/isisd/isis_spf.c
index 34fcf8f8c6..cd9a0f89bb 100644
--- a/isisd/isis_spf.c
+++ b/isisd/isis_spf.c
@@ -153,7 +153,7 @@ static int isis_vertex_queue_tent_cmp(void *a, void *b)
if (va->insert_counter > vb->insert_counter)
return 1;
- assert(!"Vertizes should be strictly ordered");
+ return 0;
}
static struct skiplist *isis_vertex_queue_skiplist(void)
diff --git a/tests/isisd/test_isis_vertex_queue.c b/tests/isisd/test_isis_vertex_queue.c
index 50436387b5..674482cd17 100644
--- a/tests/isisd/test_isis_vertex_queue.c
+++ b/tests/isisd/test_isis_vertex_queue.c
@@ -89,7 +89,7 @@ static void test_ordered(void)
assert(isis_vertex_queue_pop(&q) == vertices[1]);
assert(isis_find_vertex(&q, vertices[1]->N.id, vertices[1]->type) == NULL);
- assert(isis_vertex_queue_pop(&q) == vertices[4]);
+ isis_vertex_queue_delete(&q, vertices[4]);
assert(isis_find_vertex(&q, vertices[4]->N.id, vertices[4]->type) == NULL);
assert(isis_vertex_queue_count(&q) == 0);