diff options
| author | Donatas Abraitis <donatas@opensourcerouting.org> | 2023-08-31 17:33:57 +0300 |
|---|---|---|
| committer | Mergify <37929162+mergify[bot]@users.noreply.github.com> | 2023-08-31 15:02:58 +0000 |
| commit | 9af3d0a24f28dfeee298e9d821d7f4db2aa3b1fc (patch) | |
| tree | c7281ed223ecc421a341062d3d912eb8a2696f5b | |
| parent | 9d1ee3ade337cc195deaea76bda5b3e297df0c04 (diff) | |
Revert "bgpd: Add peers back to peer hash when peer_xfer_conn fails"
peer is NULL, but we pass it to hash_get().
This reverts commit 6f8c927b03c454aa309b84cefccc4faa31e0c03f.
(cherry picked from commit bc81691247228ad14501b86afe63dff0daf96ab6)
| -rw-r--r-- | bgpd/bgp_fsm.c | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/bgpd/bgp_fsm.c b/bgpd/bgp_fsm.c index 00aefafb3d..09b35bc7e7 100644 --- a/bgpd/bgp_fsm.c +++ b/bgpd/bgp_fsm.c @@ -2116,17 +2116,6 @@ static enum bgp_fsm_state_progress bgp_establish(struct peer *peer) peer = peer_xfer_conn(peer); if (!peer) { flog_err(EC_BGP_CONNECT, "%%Neighbor failed in xfer_conn"); - - /* - * A failure of peer_xfer_conn but not putting the peers - * back in the hash ends up with a situation where incoming - * connections are rejected, as that the peer is not found - * when a lookup is done - */ - (void)hash_get(peer->bgp->peerhash, peer, hash_alloc_intern); - if (other) - (void)hash_get(other->bgp->peerhash, other, - hash_alloc_intern); return BGP_FSM_FAILURE; } |