summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDonald Sharp <donaldsharp72@gmail.com>2023-07-25 10:29:44 -0400
committerGitHub <noreply@github.com>2023-07-25 10:29:44 -0400
commit823c5ca52dd5e9ce133d80b88f32b6c0ea710e60 (patch)
tree9112b4755813370a72eb381a5fe921102ea88c48
parent0095023cc4a50a6131a971fb182774274f17dce3 (diff)
parent9835196ec9c6ac2f058b862c1a9f401723ffd583 (diff)
Merge pull request #14072 from LabNConsulting/ziemba-pbr-coverity-230721
pbrd: fix coverity issue in pbr_map_match_vlan_tag
-rw-r--r--pbrd/pbr_vty.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/pbrd/pbr_vty.c b/pbrd/pbr_vty.c
index bc83c2d61c..8e9673482e 100644
--- a/pbrd/pbr_vty.c
+++ b/pbrd/pbr_vty.c
@@ -73,7 +73,7 @@ DEFPY(pbr_map_match_vlan_id, pbr_map_match_vlan_id_cmd,
/* clang-format off */
DEFPY(pbr_map_match_vlan_tag, pbr_map_match_vlan_tag_cmd,
- "[no] match vlan [<tagged|untagged|untagged-or-zero>$tag_type]",
+ "[no] match vlan ![<tagged|untagged|untagged-or-zero>$tag_type]",
NO_STR
"Match the rest of the command\n"
"Match based on VLAN tagging\n"
@@ -88,6 +88,7 @@ DEFPY(pbr_map_match_vlan_tag, pbr_map_match_vlan_tag_cmd,
return CMD_WARNING;
if (!no) {
+ assert(tag_type);
if (strmatch(tag_type, "tagged")) {
pbr_set_match_clause_for_vlan(pbrms, 0,
PBR_VLAN_FLAGS_TAGGED);