From 94ca37e0a9c9f7133e9b9ca3ec9d10303bca4e77 Mon Sep 17 00:00:00 2001 From: Donatas Abraitis Date: Mon, 27 Sep 2021 15:20:51 +0300 Subject: [PATCH] tools: Add coccinelle script to catch \n or \r at the end of zlog_* Signed-off-by: Donatas Abraitis --- tools/coccinelle/zlog_no_newline.cocci | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 tools/coccinelle/zlog_no_newline.cocci diff --git a/tools/coccinelle/zlog_no_newline.cocci b/tools/coccinelle/zlog_no_newline.cocci new file mode 100644 index 0000000000..20cf9d2c78 --- /dev/null +++ b/tools/coccinelle/zlog_no_newline.cocci @@ -0,0 +1,20 @@ +// zlog_* should not have \n or \r at the end usually. +// spatch --sp-file tools/coccinelle/zlog_no_newline.cocci --macro-file tools/cocci.h ./ 2>/dev/null + +@r@ +expression fmt; +identifier func =~ "zlog_"; +position p; +@@ +( + func(fmt)@p +| + func(fmt, ...)@p +) + +@script:python@ +fmt << r.fmt; +p << r.p; +@@ +if "\\n" in str(fmt) or "\\r" in str(fmt): + print("Newline in logging function detected %s:%s:%s:%s" % (p[0].file, p[0].line, p[0].column, fmt)) -- 2.39.5