From 6f3e19b736b5e7cfaf6ef5514d74358a8de182a3 Mon Sep 17 00:00:00 2001 From: Mobashshera Rasool Date: Fri, 3 Sep 2021 04:06:15 -0700 Subject: [PATCH] ospfd: Memory Leak seen at show_ip_ospf_neighbor_all_common. Problem Statement: ================== Memory Leak seen at show_ip_ospf_neighbor_all_common (ospf_vty.c:4635) RCA: ================= In function show_ip_ospf_neighbor_all_common, one child json object is not added to the parent child object when there is no nbma neighbor. Hence the memory leak. Fix: ================= Add the child object to the parent json object. Fixes: #9548 Signed-off-by: Mobashshera Rasool --- ospfd/ospf_vty.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ospfd/ospf_vty.c b/ospfd/ospf_vty.c index 515ec28b1b..1d4aa65355 100644 --- a/ospfd/ospf_vty.c +++ b/ospfd/ospf_vty.c @@ -4682,7 +4682,6 @@ static int show_ip_ospf_neighbor_all_common(struct vty *vty, struct ospf *ospf, json_vrf = json_object_new_object(); else json_vrf = json; - json_neighbor_sub = json_object_new_object(); } ospf_show_vrf_name(ospf, vty, json_vrf, use_vrf); @@ -4708,6 +4707,8 @@ static int show_ip_ospf_neighbor_all_common(struct vty *vty, struct ospf *ospf, if (nbr_nbma->nbr == NULL || nbr_nbma->nbr->state == NSM_Down) { if (use_json) { + json_neighbor_sub = + json_object_new_object(); json_object_int_add(json_neighbor_sub, "nbrNbmaPriority", nbr_nbma->priority); -- 2.39.5