From 883b4b862766352e2dd62d9645e0d0cdafb1dd8b Mon Sep 17 00:00:00 2001 From: "F. Aragon" Date: Tue, 25 Sep 2018 17:54:09 +0200 Subject: [PATCH] isisd: out of bounds access (Coverity 1473286) rawlspid_print(), which uses a fixed-width 8-byte input, has been replaced with a call to isis_format_id(), allowing giving the input size. Signed-off-by: F. Aragon --- isisd/isis_spf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/isisd/isis_spf.c b/isisd/isis_spf.c index 6a7528623c..42a019890f 100644 --- a/isisd/isis_spf.c +++ b/isisd/isis_spf.c @@ -1068,7 +1068,8 @@ static void isis_spf_loop(struct isis_spftree *spftree, lsp = lsp_for_vertex(spftree, vertex); if (!lsp) { zlog_warn("ISIS-Spf: No LSP found for %s", - rawlspid_print(vertex->N.id)); /* FIXME */ + isis_format_id(vertex->N.id, + sizeof(vertex->N.id))); continue; } -- 2.39.5