From e4407ea6d01777455b1cf0dbdee57ff70e2c3e3c Mon Sep 17 00:00:00 2001 From: paco Date: Wed, 13 Jun 2018 17:24:51 +0200 Subject: [PATCH] ospfd: buffer termination (Coverity 1464993) Signed-off-by: F. Aragon --- ospfd/ospf_ext.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ospfd/ospf_ext.c b/ospfd/ospf_ext.c index ac5df3eb4e..331cba44a8 100644 --- a/ospfd/ospf_ext.c +++ b/ospfd/ospf_ext.c @@ -1125,7 +1125,7 @@ static int ospf_ext_pref_lsa_originate1(struct ospf_area *area, if (IS_DEBUG_OSPF(lsa, LSA_GENERATE)) { char area_id[INET_ADDRSTRLEN]; - strncpy(area_id, inet_ntoa(area->area_id), INET_ADDRSTRLEN); + inet_ntop(AF_INET, &area->area_id, area_id, sizeof(area_id)); zlog_debug( "EXT (%s): LSA[Type%u:%s]: Originate Opaque-LSA " "Extended Prefix Opaque LSA: Area(%s), Link(%s)", @@ -1175,7 +1175,7 @@ static int ospf_ext_link_lsa_originate1(struct ospf_area *area, if (IS_DEBUG_OSPF(lsa, LSA_GENERATE)) { char area_id[INET_ADDRSTRLEN]; - strncpy(area_id, inet_ntoa(area->area_id), INET_ADDRSTRLEN); + inet_ntop(AF_INET, &area->area_id, area_id, sizeof(area_id)); zlog_debug( "EXT (%s): LSA[Type%u:%s]: Originate Opaque-LSA " "Extended Link Opaque LSA: Area(%s), Link(%s)", -- 2.39.5