From 77e03f051194095ea35a5a5559c35917fd9565f6 Mon Sep 17 00:00:00 2001 From: paco Date: Fri, 8 Jun 2018 18:49:36 +0200 Subject: [PATCH] zebra: resource leak fix (Coverity 1465679) Signed-off-by: F. Aragon --- zebra/zebra_vty.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c index eb11941a3a..9ce8c74220 100644 --- a/zebra/zebra_vty.c +++ b/zebra/zebra_vty.c @@ -260,18 +260,22 @@ static int zebra_static_route_holdem( return CMD_SUCCESS; } - XFREE(MTYPE_STATIC_ROUTE, shr->nhvrf_name); - XFREE(MTYPE_STATIC_ROUTE, shr->vrf_name); - XFREE(MTYPE_STATIC_ROUTE, shr); /* * If a person enters the same line again * we need to silently accept it */ - return CMD_SUCCESS; + goto shr_cleanup; } - if (!negate) + if (!negate) { listnode_add_sort(static_list, shr); + return CMD_SUCCESS; + } + +shr_cleanup: + XFREE(MTYPE_STATIC_ROUTE, shr->nhvrf_name); + XFREE(MTYPE_STATIC_ROUTE, shr->vrf_name); + XFREE(MTYPE_STATIC_ROUTE, shr); return CMD_SUCCESS; } -- 2.39.5