From 4bd04364adb27e18052730a54ee9a85ae12386c2 Mon Sep 17 00:00:00 2001 From: Donatas Abraitis Date: Sat, 8 Jul 2023 11:26:03 +0300 Subject: [PATCH] zebra: Guard printing an error by checking if VRF is not NULL Check if vrf_lookup_by_id() didn't return a NULL before dereferencing in flor_err(). Signed-off-by: Donatas Abraitis --- zebra/interface.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/zebra/interface.c b/zebra/interface.c index cf36594b34..4c9f9f3092 100644 --- a/zebra/interface.c +++ b/zebra/interface.c @@ -1531,10 +1531,16 @@ static void interface_vrf_change(enum dplane_op_e op, ifindex_t ifindex, if (exist_id != VRF_DEFAULT) { vrf = vrf_lookup_by_id(exist_id); - flog_err( - EC_ZEBRA_VRF_MISCONFIGURED, - "VRF %s id %u table id overlaps existing vrf %s(%d), misconfiguration exiting", - name, ifindex, vrf->name, vrf->vrf_id); + if (vrf) + flog_err(EC_ZEBRA_VRF_MISCONFIGURED, + "VRF %s id %u table id overlaps existing vrf %s(%d), misconfiguration exiting", + name, ifindex, vrf->name, + vrf->vrf_id); + else + flog_err(EC_ZEBRA_VRF_NOT_FOUND, + "VRF %s id %u does not exist", + name, ifindex); + exit(-1); } } -- 2.39.5