From 78946603e10489969bad3b364a96ca01d436b47d Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Wed, 19 Oct 2022 12:57:28 -0400 Subject: [PATCH] lib: Remove unnecessary comparison, for linked list In the comparison function for a linked list code was always checking against passed in NULL's. The comparison function will never receive a NULL value for data from the linklist.c code. Signed-off-by: Donald Sharp --- lib/routemap.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lib/routemap.c b/lib/routemap.c index dcaecd8085..44d7185567 100644 --- a/lib/routemap.c +++ b/lib/routemap.c @@ -1907,12 +1907,7 @@ route_map_get_index(struct route_map *map, const struct prefix *prefix, static int route_map_candidate_list_cmp(struct route_map_index *idx1, struct route_map_index *idx2) { - if (!idx1) - return -1; - if (!idx2) - return 1; - - return (idx1->pref - idx2->pref); + return idx1->pref - idx2->pref; } /* -- 2.39.5