From f580074e61d487fd83d0160629b1de3486df98b2 Mon Sep 17 00:00:00 2001 From: Mark Stapp Date: Tue, 5 Jul 2022 16:31:41 -0400 Subject: [PATCH] lib: fix SA warning in typesafe code There's a nagging SA warning, at least with the scan-build version we use in the FRR CI. Signed-off-by: Mark Stapp --- lib/typesafe.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/typesafe.h b/lib/typesafe.h index 06fdc52e78..df963f530d 100644 --- a/lib/typesafe.h +++ b/lib/typesafe.h @@ -309,7 +309,8 @@ static inline void typesafe_dlist_add(struct dlist_head *head, struct dlist_item *prev, struct dlist_item *item) { item->next = prev->next; - item->next->prev = item; + if (item->next) + item->next->prev = item; item->prev = prev; prev->next = item; head->count++; -- 2.39.5