From 943bfc4e824372a4eb036098464a301e9392f5dd Mon Sep 17 00:00:00 2001 From: Philippe Guibert Date: Mon, 4 Jul 2022 16:53:47 +0200 Subject: [PATCH] topotests: add bgp retain test This test checks that when retain functionality is disabled, some prefixes are removed from the BGP ipv4 vpn RIB. Signed-off-by: Philippe Guibert --- .../topotests/bgp_vpnv4_noretain/__init__.py | 0 .../topotests/bgp_vpnv4_noretain/r1/bgpd.conf | 24 +++ .../r1/ipv4_vpn_routes.json | 69 ++++++ .../r1/ipv4_vpn_routes_unfiltered.json | 94 ++++++++ .../bgp_vpnv4_noretain/r1/isisd.conf | 14 ++ .../bgp_vpnv4_noretain/r1/zebra.conf | 13 ++ .../topotests/bgp_vpnv4_noretain/r2/bgpd.conf | 35 +++ .../bgp_vpnv4_noretain/r2/isisd.conf | 14 ++ .../bgp_vpnv4_noretain/r2/zebra.conf | 16 ++ .../test_bgp_vpnv4_noretain.py | 201 ++++++++++++++++++ 10 files changed, 480 insertions(+) create mode 100644 tests/topotests/bgp_vpnv4_noretain/__init__.py create mode 100644 tests/topotests/bgp_vpnv4_noretain/r1/bgpd.conf create mode 100644 tests/topotests/bgp_vpnv4_noretain/r1/ipv4_vpn_routes.json create mode 100644 tests/topotests/bgp_vpnv4_noretain/r1/ipv4_vpn_routes_unfiltered.json create mode 100644 tests/topotests/bgp_vpnv4_noretain/r1/isisd.conf create mode 100644 tests/topotests/bgp_vpnv4_noretain/r1/zebra.conf create mode 100644 tests/topotests/bgp_vpnv4_noretain/r2/bgpd.conf create mode 100644 tests/topotests/bgp_vpnv4_noretain/r2/isisd.conf create mode 100644 tests/topotests/bgp_vpnv4_noretain/r2/zebra.conf create mode 100644 tests/topotests/bgp_vpnv4_noretain/test_bgp_vpnv4_noretain.py diff --git a/tests/topotests/bgp_vpnv4_noretain/__init__.py b/tests/topotests/bgp_vpnv4_noretain/__init__.py new file mode 100644 index 0000000000..e69de29bb2 diff --git a/tests/topotests/bgp_vpnv4_noretain/r1/bgpd.conf b/tests/topotests/bgp_vpnv4_noretain/r1/bgpd.conf new file mode 100644 index 0000000000..3d8773b8bf --- /dev/null +++ b/tests/topotests/bgp_vpnv4_noretain/r1/bgpd.conf @@ -0,0 +1,24 @@ +router bgp 65500 + bgp router-id 1.1.1.1 + neighbor 10.125.0.2 remote-as 65500 + address-family ipv4 unicast + no neighbor 10.125.0.2 activate + exit-address-family + address-family ipv4 vpn + neighbor 10.125.0.2 activate + no bgp retain route-target all + exit-address-family +! +router bgp 65500 vrf vrf1 + bgp router-id 1.1.1.1 + address-family ipv4 unicast + redistribute connected + label vpn export 101 + rd vpn export 444:1 + rt vpn import 51:100 52:100 + rt vpn export 51:100 + export vpn + import vpn + exit-address-family +! + diff --git a/tests/topotests/bgp_vpnv4_noretain/r1/ipv4_vpn_routes.json b/tests/topotests/bgp_vpnv4_noretain/r1/ipv4_vpn_routes.json new file mode 100644 index 0000000000..903c4603c5 --- /dev/null +++ b/tests/topotests/bgp_vpnv4_noretain/r1/ipv4_vpn_routes.json @@ -0,0 +1,69 @@ +{ + "vrfId":0, + "vrfName":"default", + "tableVersion":1, + "routerId":"1.1.1.1", + "defaultLocPrf":100, + "localAS":65500, + "routes":{ + "routeDistinguishers":{ + "444:1":{ + "10.201.0.0/24":[ + { + "valid":true, + "bestpath":true, + "selectionReason":"First path received", + "pathFrom":"external", + "prefix":"10.201.0.0", + "prefixLen":24, + "network":"10.201.0.0\/24", + "version":1, + "metric":0, + "weight":32768, + "peerId":"(unspec)", + "path":"", + "origin":"incomplete", + "announceNexthopSelf":true, + "nhVrfName":"vrf1", + "nexthops":[ + { + "ip":"0.0.0.0", + "afi":"ipv4", + "used":true + } + ] + } + ] + }, + "444:2":{ + "10.200.0.0/24":[ + { + "valid":true, + "bestpath":true, + "selectionReason":"First path received", + "pathFrom":"internal", + "prefix":"10.200.0.0", + "prefixLen":24, + "network":"10.200.0.0\/24", + "version":1, + "metric":0, + "locPrf":100, + "weight":0, + "peerId":"10.125.0.2", + "path":"", + "origin":"incomplete", + "nexthops":[ + { + "ip":"10.125.0.2", + "afi":"ipv4", + "used":true + } + ] + } + ] + }, + "444:3":{ + } + } + } +} diff --git a/tests/topotests/bgp_vpnv4_noretain/r1/ipv4_vpn_routes_unfiltered.json b/tests/topotests/bgp_vpnv4_noretain/r1/ipv4_vpn_routes_unfiltered.json new file mode 100644 index 0000000000..3cc0b4a5f5 --- /dev/null +++ b/tests/topotests/bgp_vpnv4_noretain/r1/ipv4_vpn_routes_unfiltered.json @@ -0,0 +1,94 @@ +{ + "vrfId":0, + "vrfName":"default", + "tableVersion":1, + "routerId":"1.1.1.1", + "defaultLocPrf":100, + "localAS":65500, + "routes":{ + "routeDistinguishers":{ + "444:1":{ + "10.201.0.0/24":[ + { + "valid":true, + "bestpath":true, + "selectionReason":"First path received", + "pathFrom":"external", + "prefix":"10.201.0.0", + "prefixLen":24, + "network":"10.201.0.0\/24", + "version":1, + "metric":0, + "weight":32768, + "peerId":"(unspec)", + "path":"", + "origin":"incomplete", + "announceNexthopSelf":true, + "nhVrfName":"vrf1", + "nexthops":[ + { + "ip":"0.0.0.0", + "afi":"ipv4", + "used":true + } + ] + } + ] + }, + "444:2":{ + "10.200.0.0/24":[ + { + "valid":true, + "bestpath":true, + "selectionReason":"First path received", + "pathFrom":"internal", + "prefix":"10.200.0.0", + "prefixLen":24, + "network":"10.200.0.0\/24", + "version":1, + "metric":0, + "locPrf":100, + "weight":0, + "peerId":"10.125.0.2", + "path":"", + "origin":"incomplete", + "nexthops":[ + { + "ip":"10.125.0.2", + "afi":"ipv4", + "used":true + } + ] + } + ] + }, + "444:3":{ + "10.210.0.0/24":[ + { + "valid":true, + "bestpath":true, + "selectionReason":"First path received", + "pathFrom":"internal", + "prefix":"10.210.0.0", + "prefixLen":24, + "network":"10.210.0.0\/24", + "version":1, + "metric":0, + "locPrf":100, + "weight":0, + "peerId":"10.125.0.2", + "path":"", + "origin":"incomplete", + "nexthops":[ + { + "ip":"10.125.0.2", + "afi":"ipv4", + "used":true + } + ] + } + ] + } + } + } +} diff --git a/tests/topotests/bgp_vpnv4_noretain/r1/isisd.conf b/tests/topotests/bgp_vpnv4_noretain/r1/isisd.conf new file mode 100644 index 0000000000..6f5cb6ec68 --- /dev/null +++ b/tests/topotests/bgp_vpnv4_noretain/r1/isisd.conf @@ -0,0 +1,14 @@ +interface r1-eth0 + ip router isis 1 + isis circuit-type level-1 +! +interface lo + ip router isis 1 + isis passive +! +router isis 1 + is-type level-1 + net 49.0002.0000.1994.00 + segment-routing on + segment-routing prefix 1.1.1.1/32 index 11 +! diff --git a/tests/topotests/bgp_vpnv4_noretain/r1/zebra.conf b/tests/topotests/bgp_vpnv4_noretain/r1/zebra.conf new file mode 100644 index 0000000000..5b8b1e8ffb --- /dev/null +++ b/tests/topotests/bgp_vpnv4_noretain/r1/zebra.conf @@ -0,0 +1,13 @@ +log stdout +interface lo + ip address 1.1.1.1/32 +! +interface r1-gre0 + ip address 192.168.0.1/24 +! +interface r1-eth1 vrf vrf1 + ip address 10.201.0.1/24 +! +interface r1-eth0 + ip address 10.125.0.1/24 +! diff --git a/tests/topotests/bgp_vpnv4_noretain/r2/bgpd.conf b/tests/topotests/bgp_vpnv4_noretain/r2/bgpd.conf new file mode 100644 index 0000000000..235fb31177 --- /dev/null +++ b/tests/topotests/bgp_vpnv4_noretain/r2/bgpd.conf @@ -0,0 +1,35 @@ +router bgp 65500 + bgp router-id 2.2.2.2 + neighbor 10.125.0.1 remote-as 65500 + address-family ipv4 unicast + no neighbor 10.125.0.1 activate + exit-address-family + address-family ipv4 vpn + neighbor 10.125.0.1 activate + no bgp retain route-target all + exit-address-family +! +router bgp 65500 vrf vrf1 + bgp router-id 2.2.2.2 + address-family ipv4 unicast + redistribute connected + label vpn export 102 + rd vpn export 444:2 + rt vpn import 53:100 52:100 51:100 + rt vpn export 52:100 + export vpn + import vpn + exit-address-family +! +router bgp 65500 vrf vrf2 + bgp router-id 2.2.2.2 + address-family ipv4 unicast + redistribute connected + label vpn export 102 + rd vpn export 444:3 + rt vpn both 53:100 52:100 51:100 + rt vpn both 53:100 + export vpn + import vpn + exit-address-family +! diff --git a/tests/topotests/bgp_vpnv4_noretain/r2/isisd.conf b/tests/topotests/bgp_vpnv4_noretain/r2/isisd.conf new file mode 100644 index 0000000000..cbec8c3674 --- /dev/null +++ b/tests/topotests/bgp_vpnv4_noretain/r2/isisd.conf @@ -0,0 +1,14 @@ +interface r2-eth0 + ip router isis 1 + isis circuit-type level-1 +! +interface lo + ip router isis 1 + isis passive +! +router isis 1 + is-type level-1 + net 49.0002.0000.1995.00 + segment-routing on + segment-routing prefix 2.2.2.2/32 index 22 +! diff --git a/tests/topotests/bgp_vpnv4_noretain/r2/zebra.conf b/tests/topotests/bgp_vpnv4_noretain/r2/zebra.conf new file mode 100644 index 0000000000..7ec644ac2a --- /dev/null +++ b/tests/topotests/bgp_vpnv4_noretain/r2/zebra.conf @@ -0,0 +1,16 @@ +log stdout +interface lo + ip address 2.2.2.2/32 +! +interface r2-gre0 + ip address 192.168.0.2/24 +! +interface r2-eth1 vrf vrf1 + ip address 10.200.0.2/24 +! +interface r2-eth2 vrf vrf2 + ip address 10.210.0.2/24 +! +interface r2-eth0 + ip address 10.125.0.2/24 +! diff --git a/tests/topotests/bgp_vpnv4_noretain/test_bgp_vpnv4_noretain.py b/tests/topotests/bgp_vpnv4_noretain/test_bgp_vpnv4_noretain.py new file mode 100644 index 0000000000..b4a841d9cf --- /dev/null +++ b/tests/topotests/bgp_vpnv4_noretain/test_bgp_vpnv4_noretain.py @@ -0,0 +1,201 @@ +#!/usr/bin/env python + +# +# test_bgp_vpnv4_noretain.py +# Part of NetDEF Topology Tests +# +# Copyright 2022 6WIND S.A. +# +# Permission to use, copy, modify, and/or distribute this software +# for any purpose with or without fee is hereby granted, provided +# that the above copyright notice and this permission notice appear +# in all copies. +# +# THE SOFTWARE IS PROVIDED "AS IS" AND NETDEF DISCLAIMS ALL WARRANTIES +# WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +# MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL NETDEF BE LIABLE FOR +# ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY +# DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, +# WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS +# ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE +# OF THIS SOFTWARE. +# + +""" + test_bgp_vpnv4_noretain.py: Do not keep the VPNvx entries when no + VRF matches incoming VPNVx entries +""" + +import os +import sys +import json +from functools import partial +import pytest + +# Save the Current Working Directory to find configuration files. +CWD = os.path.dirname(os.path.realpath(__file__)) +sys.path.append(os.path.join(CWD, "../")) + +# pylint: disable=C0413 +# Import topogen and topotest helpers +from lib import topotest +from lib.topogen import Topogen, TopoRouter, get_topogen +from lib.topolog import logger + +# Required to instantiate the topology builder class. + + +pytestmark = [pytest.mark.bgpd] + +def build_topo(tgen): + "Build function" + + tgen.add_router("r1") + tgen.add_router("r2") + + switch = tgen.add_switch("s1") + switch.add_link(tgen.gears["r1"]) + switch.add_link(tgen.gears["r2"]) + + switch = tgen.add_switch("s2") + switch.add_link(tgen.gears["r1"]) + + switch = tgen.add_switch("s3") + switch.add_link(tgen.gears["r2"]) + + switch = tgen.add_switch("s4") + switch.add_link(tgen.gears["r2"]) + + +def _populate_iface(): + tgen = get_topogen() + cmds_list = [ + 'modprobe mpls_router', + 'echo 100000 > /proc/sys/net/mpls/platform_labels', + 'ip link add vrf1 type vrf table 10', + 'ip link set dev vrf1 up', + 'ip link set dev {0}-eth1 master vrf1', + 'echo 1 > /proc/sys/net/mpls/conf/vrf1/input', + ] + cmds_list_extra = [ + 'ip link add vrf2 type vrf table 20', + 'ip link set dev vrf2 up', + 'ip link set dev {0}-eth2 master vrf2', + 'echo 1 > /proc/sys/net/mpls/conf/vrf2/input', + ] + + for cmd in cmds_list: + input = cmd.format('r1', '1', '2') + logger.info('input: ' + cmd) + output = tgen.net['r1'].cmd(cmd.format('r1', '1', '2')) + logger.info('output: ' + output) + + for cmd in cmds_list: + input = cmd.format('r2', '2', '1') + logger.info('input: ' + cmd) + output = tgen.net['r2'].cmd(cmd.format('r2', '2', '1')) + logger.info('output: ' + output) + + for cmd in cmds_list_extra: + input = cmd.format('r2', '2', '1') + logger.info('input: ' + cmd) + output = tgen.net['r2'].cmd(cmd.format('r2', '2', '1')) + logger.info('output: ' + output) + +def setup_module(mod): + "Sets up the pytest environment" + + tgen = Topogen(build_topo, mod.__name__) + tgen.start_topology() + + router_list = tgen.routers() + _populate_iface() + + for rname, router in router_list.items(): + router.load_config( + TopoRouter.RD_ZEBRA, os.path.join(CWD, "{}/zebra.conf".format(rname)) + ) + router.load_config( + TopoRouter.RD_BGP, os.path.join(CWD, "{}/bgpd.conf".format(rname)) + ) + router.load_config( + TopoRouter.RD_ISIS, os.path.join(CWD, "{}/bgpd.conf".format(rname)) + ) + + # Initialize all routers. + tgen.start_router() + + +def teardown_module(_mod): + "Teardown the pytest environment" + tgen = get_topogen() + + tgen.stop_topology() + + +def test_protocols_convergence(): + """ + Assert that all protocols have converged + statuses as they depend on it. + """ + tgen = get_topogen() + if tgen.routers_have_failure(): + pytest.skip(tgen.errors) + + # Check IPv4 VPN routing tables on r1 + logger.info("Checking IPv4 routes for convergence on r1") + router = tgen.gears['r1'] + json_file = "{}/{}/ipv4_vpn_routes.json".format(CWD, router.name) + if not os.path.isfile(json_file): + logger.info("skipping file {}".format(json_file)) + assert 0, 'ipv4_vpn_routes.json file not found' + return + + expected = json.loads(open(json_file).read()) + test_func = partial( + topotest.router_json_cmp, + router, + "show bgp ipv4 vpn json", + expected, + ) + _, result = topotest.run_and_expect(test_func, None, count=10, wait=0.5) + assertmsg = '"{}" JSON output mismatches'.format(router.name) + assert result is None, assertmsg + + # Check BGP IPv4 routing tables after unsetting no retain flag + logger.info("Checking BGP IPv4 routes for convergence on r2") + router = tgen.gears['r1'] + router.vtysh_cmd("configure\nrouter bgp 65500\naddress-family ipv4 vpn\nbgp retain route-target all\n") + + # Check IPv4 VPN routing tables on r1 + logger.info("Checking IPv4 routes for convergence on r1") + router = tgen.gears['r1'] + json_file = "{}/{}/ipv4_vpn_routes_unfiltered.json".format(CWD, router.name) + if not os.path.isfile(json_file): + logger.info("skipping file {}".format(json_file)) + assert 0, 'ipv4_vpn_routes_unfiltered.json file not found' + return + + expected = json.loads(open(json_file).read()) + test_func = partial( + topotest.router_json_cmp, + router, + "show bgp ipv4 vpn json", + expected, + ) + _, result = topotest.run_and_expect(test_func, None, count=10, wait=0.5) + assertmsg = '"{}" JSON output mismatches'.format(router.name) + assert result is None, assertmsg + +def test_memory_leak(): + "Run the memory leak test and report results." + tgen = get_topogen() + if not tgen.is_memleak_enabled(): + pytest.skip("Memory leak test/report is disabled") + + tgen.report_memory_leaks() + + +if __name__ == "__main__": + args = ["-s"] + sys.argv[1:] + sys.exit(pytest.main(args)) -- 2.39.5