From f65fb6b4b4530b6f4aa7408a4e256017ccb0f2c2 Mon Sep 17 00:00:00 2001 From: Renato Westphal Date: Mon, 14 Jan 2019 16:29:18 -0200 Subject: [PATCH] lib: fix "use of uninitialised value" valgrind warning When FRR is built without the --enable-config-rollbacks option, the nb_db_transaction_save() function does nothing and the "transaction_id" output parameter is left uninitialized. For this reason, all northbound clients should initialize the "transaction_id" argument before calling nb_candidate_commit() or nb_candidate_commit_apply() (except when a NULL pointer is given, which is the case of the confd and sysrepo plugins). Signed-off-by: Renato Westphal --- lib/northbound_cli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/northbound_cli.c b/lib/northbound_cli.c index 2b024ace93..33035de31b 100644 --- a/lib/northbound_cli.c +++ b/lib/northbound_cli.c @@ -261,7 +261,7 @@ static int nb_cli_confirmed_commit_timeout(struct thread *thread) static int nb_cli_commit(struct vty *vty, bool force, unsigned int confirmed_timeout, char *comment) { - uint32_t transaction_id; + uint32_t transaction_id = 0; int ret; /* Check if there's a pending confirmed commit. */ -- 2.39.5