From f5ad8efc4e5fadd24311c06afb2c93a0eb65a575 Mon Sep 17 00:00:00 2001 From: Stefan Hanreich Date: Fri, 7 Mar 2025 13:50:55 +0100 Subject: [PATCH] subnet: dhcp: only accept single ips and normalize them Net::IP accepts a myriad of different IP objects from ranges to prefixes to singular IPs. We check if the object consists only of a singular IP and normalize the IP if it has size 1 (since then it could still be a /32 prefix or a range consisting of one IP). Otherwise we would theoretically accept any valid Net::IP object here. Signed-off-by: Stefan Hanreich Tested-by: Hannes Duerr Link: https://lore.proxmox.com/20250307125056.169575-3-s.hanreich@proxmox.com Signed-off-by: Thomas Lamprecht --- src/PVE/Network/SDN/SubnetPlugin.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/PVE/Network/SDN/SubnetPlugin.pm b/src/PVE/Network/SDN/SubnetPlugin.pm index 107e2f7..81adc88 100644 --- a/src/PVE/Network/SDN/SubnetPlugin.pm +++ b/src/PVE/Network/SDN/SubnetPlugin.pm @@ -88,9 +88,13 @@ sub validate_dhcp_ranges { my $start_ip = Net::IP->new($dhcp_start); raise_param_exc({ 'dhcp-range' => "start-address is not a valid IP $dhcp_start" }) if !$start_ip; + raise_param_exc({ 'dhcp-range' => "start-address must be a singular IP" }) if $start_ip->size() != 1; + $dhcp_range->{'start-address'} = $start_ip->ip(); my $end_ip = Net::IP->new($dhcp_end); raise_param_exc({ 'dhcp-range' => "end-address is not a valid IP $dhcp_end" }) if !$end_ip; + raise_param_exc({ 'dhcp-range' => "end-address must be a singular IP" }) if $end_ip->size() != 1; + $dhcp_range->{'end-address'} = $end_ip->ip(); if ($start_ip->bincomp('gt', $end_ip)) { raise_param_exc({ 'dhcp-range' => "start-address $dhcp_start must be smaller than end-address $dhcp_end" }) -- 2.39.5